From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gleb Natapov <gleb@redhat.com>
Subject: Re: [PATCH] kvm-unit-tests: Test case of emulating multibyte NOP
Date: Thu, 6 Jun 2013 10:46:01 +0300
Message-ID: <20130606074601.GX4725@redhat.com>
References: <1370504309-6985-1-git-send-email-yzt356@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: kvm@vger.kernel.org, pbonzini@redhat.com
To: Arthur Chunqi Li <yzt356@gmail.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:19989 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1756066Ab3FFHqF (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 6 Jun 2013 03:46:05 -0400
Content-Disposition: inline
In-Reply-To: <1370504309-6985-1-git-send-email-yzt356@gmail.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Thu, Jun 06, 2013 at 03:38:29PM +0800, Arthur Chunqi Li wrote:
> Add multibyte (1 to 4-bytes) NOPL test case to kvm-unit-tests
> x86/realmode.c. This test only consist of 16-bit NOPL insn,
> other test cases (5 to 9-bytes NOPL) should be placed
> in x86/emulator.c.
> 
Applied, thanks!

> Signed-off-by: Arthur Chunqi Li <yzt356@gmail.com>
> ---
>  x86/realmode.c |   14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/x86/realmode.c b/x86/realmode.c
> index 981be08..3546771 100644
> --- a/x86/realmode.c
> +++ b/x86/realmode.c
> @@ -1504,6 +1504,19 @@ static void test_fninit(void)
>  	report("fninit", 0, fsw == 0 && (fcw & 0x103f) == 0x003f);
>  }
>  
> +static void test_nopl(void)
> +{
> +	MK_INSN(nopl1, ".byte 0x90\n\r"); // 1 byte nop
> +	MK_INSN(nopl2, ".byte 0x66, 0x90\n\r"); // 2 bytes nop
> +	MK_INSN(nopl3, ".byte 0x0f, 0x1f, 0x00\n\r"); // 3 bytes nop
> +	MK_INSN(nopl4, ".byte 0x0f, 0x1f, 0x40, 0x00\n\r"); // 4 bytes nop
> +	exec_in_big_real_mode(&insn_nopl1);
> +	exec_in_big_real_mode(&insn_nopl2);
> +	exec_in_big_real_mode(&insn_nopl3);
> +	exec_in_big_real_mode(&insn_nopl4);
> +	report("nopl", 0, 1);
> +}
> +
>  void realmode_start(void)
>  {
>  	test_null();
> @@ -1548,6 +1561,7 @@ void realmode_start(void)
>  	test_xlat();
>  	test_salc();
>  	test_fninit();
> +	test_nopl();
>  
>  	exit(0);
>  }
> -- 
> 1.7.9.5

--
			Gleb.