From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gleb Natapov Subject: Regression after "Remove support for reporting coalesced APIC IRQs" Date: Thu, 6 Jun 2013 11:53:52 +0300 Message-ID: <20130606085352.GZ4725@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, yongjie.ren@intel.com To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:11847 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751061Ab3FFIyA (ORCPT ); Thu, 6 Jun 2013 04:54:00 -0400 Content-Disposition: inline Sender: kvm-owner@vger.kernel.org List-ID: Hi Jan, I bisected [1] to f1ed0450a5fac7067590317cbf027f566b6ccbca. Fortunately further investigation showed that it is not really related to removing APIC timer interrupt reinjection and the real problem is that we cannot assume that __apic_accept_irq() always injects interrupts like the patch does because the function skips interrupt injection if APIC is disabled. This misreporting screws RTC interrupt tracking, so further RTC interrupt are stopped to be injected. The simplest solution that I see is to revert most of the commit and only leave APIC timer interrupt reinjection. If you have more elegant solution let me know. [1] https://bugzilla.kernel.org/show_bug.cgi?id=58931 -- Gleb.