All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Eric Leblond <eric@regit.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [nftables PATCH 0/5] misc fixes
Date: Thu, 6 Jun 2013 13:43:10 +0200	[thread overview]
Message-ID: <20130606114310.GA9849@localhost> (raw)
In-Reply-To: <1370169512-23500-1-git-send-email-eric@regit.org>

Hi Eric,

On Sun, Jun 02, 2013 at 12:38:27PM +0200, Eric Leblond wrote:
> 
> Hello,
> 
> Here's a small patchset for nftables. It contains miscellaneous fixes
> and improvements. I'm not sure for patch 2 ("expression") because it
> may not be the best way to fix the crash.

I just sent you a patch to address this issue. I cannot find any
problem with yours though, but I think it's better if we don't make
any assumption and explicitly label dynamically allocated datatypes to
differenciate them of static ones.

> Patch 3 can also be discussed because it suppress something that was
> done before in the code.

Can you point to the patch that changed that line of code, I'm lacking
some context.

Regarding Patch 1, 4 and 5. Feel free to push them to the nftables
tree.

Thanks.

  parent reply	other threads:[~2013-06-06 11:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-02 10:38 [nftables PATCH 0/5] misc fixes Eric Leblond
2013-06-02 10:38 ` [nftables PATCH 1/5] doc: fix inversion of operator and object Eric Leblond
2013-06-02 10:38 ` [nftables PATCH 2/5] expression: don't free TYPE_INVALID datatype Eric Leblond
2013-06-02 10:38 ` [nftables PATCH 3/5] rule: list elements in set in any case Eric Leblond
2013-06-02 10:38 ` [nftables PATCH 4/5] cli: add quit command Eric Leblond
2013-06-02 10:38 ` [nftables PATCH 5/5] cli: reset terminal when CTRL+d is pressed Eric Leblond
2013-06-06 11:43 ` Pablo Neira Ayuso [this message]
2013-06-06 12:02   ` [nftables PATCH 0/5] misc fixes Pablo Neira Ayuso
2013-06-08 10:12     ` Eric Leblond

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130606114310.GA9849@localhost \
    --to=pablo@netfilter.org \
    --cc=eric@regit.org \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.