From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Ming Lei <ming.lei@canonical.com>
Cc: linux-kernel@vger.kernel.org, Takashi Iwai <tiwai@suse.de>
Subject: Re: [RFC PATCH v1 4/4] firmware loader: don't allow to request firmware via relative path
Date: Thu, 6 Jun 2013 21:21:31 -0700 [thread overview]
Message-ID: <20130607042131.GC3603@kroah.com> (raw)
In-Reply-To: <CACVXFVPtLHCNhuybkgUiHEYEcaB6BdCZs6M7QLHHsNdMfCtzug@mail.gmail.com>
On Fri, Jun 07, 2013 at 09:30:09AM +0800, Ming Lei wrote:
> On Fri, Jun 7, 2013 at 3:48 AM, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> > On Thu, Jun 06, 2013 at 08:01:50PM +0800, Ming Lei wrote:
> >> It isn't a good pratice to request firmware via relative path, also
> >> might have security issue, so don't do it.
> >
> > What would the security issue be? You are letting the person who build
> > the kernel specify this, so they can put whatever they want in here, a
> > '..' isn't going to keep them from being able to do "bad" things if they
> > really want to.
>
> In VM case, guest kernel might access host filesystem files via this trick,
> but not sure if it is possible.
How can a ".." do anything with guest kernels that total control over a
path not do?
thanks,
greg k-h
next prev parent reply other threads:[~2013-06-07 4:21 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-06 12:01 [PATCH v1 0/4] firmware loader: cleanup and introduce search paths option Ming Lei
2013-06-06 12:01 ` [PATCH v1 1/4] firmware loader: don't export cache_firmware and uncache_firmware Ming Lei
2013-06-06 12:01 ` [PATCH v1 2/4] firmware loader: simplify holding module for request_firmware Ming Lei
2014-01-07 7:56 ` Dmitry Torokhov
2014-01-07 14:53 ` Ming Lei
2014-01-07 17:23 ` Dmitry Torokhov
2013-06-06 12:01 ` [PATCH v1 3/4] firmware loader: allow distribution to choose default search paths Ming Lei
2013-06-06 19:47 ` Greg Kroah-Hartman
2013-06-07 1:24 ` Ming Lei
2013-06-07 4:20 ` Greg Kroah-Hartman
2013-06-07 15:01 ` Ming Lei
2013-06-06 12:01 ` [RFC PATCH v1 4/4] firmware loader: don't allow to request firmware via relative path Ming Lei
2013-06-06 19:48 ` Greg Kroah-Hartman
2013-06-07 1:30 ` Ming Lei
2013-06-07 4:21 ` Greg Kroah-Hartman [this message]
2013-06-07 6:04 ` Takashi Iwai
2013-06-07 14:54 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130607042131.GC3603@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@canonical.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.