Re: [PATCH] libxl: add LIBXL_HAVE_<foo> for outstanding_pages and outstanding_memkb

[Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>]

On Fri, Jun 07, 2013 at 12:50:41AM +0200, Dario Faggioli wrote:
> Commits d0782481 and bec8f17e added these two fields in libxl_physinfo

One usually includes right after the git commit the title
of the patches, so:

d0782481 ("xl: export 'outstanding_pages' value from xcinfo") and
...
> and in libxl_dominfo, respectively, but did not include the needed
> LIBXL_HAVE_<foo> runes. Adding them.
> 
> Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>

Besides the above mention commit description part (And one tweak below)
please also add
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>

or Acked-by - whichever George is looking for.

> ---
>  tools/libxl/libxl.h |   18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 
> diff --git a/tools/libxl/libxl.h b/tools/libxl/libxl.h
> index 0bc005e..3d3bbdd 100644
> --- a/tools/libxl/libxl.h
> +++ b/tools/libxl/libxl.h
> @@ -318,6 +318,24 @@
>  #define LIBXL_HAVE_NONCONST_EVENT_OCCURS_EVENT_ARG 1
>  #endif
>  
> +/*
> + * LIBXL_HAVE_PHYSINFO_OUTSTANDING_PAGES
> + *
> + * If this is defined, libxl_physinfo structure will contain an uint64 field
> + * called outstanding_pages, containing the number of pages claimed but not
> + * yet allocated.

.. for all domains.

> + */
> +#define LIBXL_HAVE_PHYSINFO_OUTSTANDING_PAGES 1
> +
> +/*
> + * LIBXL_HAVE_DOMINFO_OUTSTANDING_MEMKB 1
> + *
> + * If this is defined, libxl_dominfo will contain a MemKB type field called
> + * outstanding_memkb, containing the amount of claimed but not yet allocated
> + * memory for a specific domain.
> + */
> +#define LIBXL_HAVE_DOMINFO_OUTSTANDING_MEMKB 1
> +
>  /* Functions annotated with LIBXL_EXTERNAL_CALLERS_ONLY may not be
>   * called from within libxl itself. Callers outside libxl, who
>   * do not #include libxl_internal.h, are fine. */
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
>