From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: puzzling code in nvme_configure_admin_queue()
Date: Fri, 07 Jun 2013 20:55:09 +0000 [thread overview]
Message-ID: <20130607161218.GU23987@mwanda> (raw)
In-Reply-To: <20130607114503.GA7768@debian>
On Fri, Jun 07, 2013 at 01:44:24PM +0000, Wilcox, Matthew R wrote:
> Hi Dan,
>
> We have to program the device with the page size so it knows where the page boundaries are.
> I could put all this on one logical line like this:
>
> dev->ctrl_config = NVME_CC_ENABLE | NVME_CC_CSS_NVM |
> ((PAGE_SHIFT - 12) << NVME_CC_MPS_SHIFT |
> NVME_CC_ARB_RR | NVME_CC_SHN_NONE |
> NVME_CC_IOSQES | NVME_CC_IOCQES;
>
> in order to shut up the warning, but is that really more readable?
It wouldn't shut up the complaint either...
No worries.
regards,
dan carpenter
prev parent reply other threads:[~2013-06-07 20:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-07 11:45 puzzling code in nvme_configure_admin_queue() Dan Carpenter
2013-06-07 13:44 ` Wilcox, Matthew R
2013-06-07 20:55 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130607161218.GU23987@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.