From: Guenter Roeck <linux@roeck-us.net>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH 1/2] hwmon: (adm1021) Do not create min sysfs attributes for LM84
Date: Fri, 07 Jun 2013 16:27:17 +0000 [thread overview]
Message-ID: <20130607162717.GA4725@roeck-us.net> (raw)
In-Reply-To: <1370620280-32415-1-git-send-email-linux@roeck-us.net>
On Fri, Jun 07, 2013 at 06:07:28PM +0200, Jean Delvare wrote:
> On Fri, 7 Jun 2013 08:51:19 -0700, Guenter Roeck wrote:
> > LM84 does not support minimum temperature registers.
> > Only create the respective sysfs attributes for other chips.
>
> Did you consider implementing this with .is_visible()? This might
> result in a smaller binary.
>
Hi Jean,
Turns out it is larger: 8575 bytes vs. 8516 bytes. Cost of cleaner code :(.
> Other than that, this looks good:
>
> Acked-by: Jean Delvare <khali@linux-fr.org>
>
Thanks - I'll keep it as-is (using multiple groups).
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
prev parent reply other threads:[~2013-06-07 16:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-07 15:51 [lm-sensors] [PATCH 1/2] hwmon: (adm1021) Do not create min sysfs attributes for LM84 Guenter Roeck
2013-06-07 16:07 ` Jean Delvare
2013-06-07 16:27 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130607162717.GA4725@roeck-us.net \
--to=linux@roeck-us.net \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.