From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Fri, 7 Jun 2013 21:18:16 +0200 Subject: [PATCH 11/14] ARM: mvebu: Relocate Armada 370/XP DeviceBus device tree nodes In-Reply-To: <1370623671-7748-12-git-send-email-ezequiel.garcia@free-electrons.com> References: <1370623671-7748-1-git-send-email-ezequiel.garcia@free-electrons.com> <1370623671-7748-12-git-send-email-ezequiel.garcia@free-electrons.com> Message-ID: <201306072118.16730.arnd@arndb.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Friday 07 June 2013, Ezequiel Garcia wrote: > --- a/arch/arm/boot/dts/armada-370-xp.dtsi > +++ b/arch/arm/boot/dts/armada-370-xp.dtsi > @@ -34,6 +34,51 @@ > compatible = "simple-bus"; > interrupt-parent = <&mpic>; > > + devbus-bootcs { > + compatible = "marvell,mvebu-devbus"; > + reg = <0 0x10400 0x8>; > + #address-cells = <1>; > + #size-cells = <1>; > + clocks = <&coreclk 0>; > + status = "disabled"; > + }; > + ... > internal-regs { > compatible = "simple-bus"; > #address-cells = <1>; I think you are missing a couple of things here: * The mbus node needs #address-cells and #size-cells, and is no longer compatible="simple-bus"m since it's actually complex. * The devbus-bootcs node and all other ones need "ranges" properties. * The "reg" property of the devbus-bootcs device needs to be in mbus translated address space, so I assume the first cell would be something other than '0'. * With the proposal I made for patch 3, you would actually need a ranges property for the mbus node as well. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH 11/14] ARM: mvebu: Relocate Armada 370/XP DeviceBus device tree nodes Date: Fri, 7 Jun 2013 21:18:16 +0200 Message-ID: <201306072118.16730.arnd@arndb.de> References: <1370623671-7748-1-git-send-email-ezequiel.garcia@free-electrons.com> <1370623671-7748-12-git-send-email-ezequiel.garcia@free-electrons.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1370623671-7748-12-git-send-email-ezequiel.garcia-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Ezequiel Garcia Cc: Lior Amsalem , Jason Cooper , Andrew Lunn , devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Jason Gunthorpe , Maen Suleiman , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Sebastian Hesselbarth List-Id: devicetree@vger.kernel.org On Friday 07 June 2013, Ezequiel Garcia wrote: > --- a/arch/arm/boot/dts/armada-370-xp.dtsi > +++ b/arch/arm/boot/dts/armada-370-xp.dtsi > @@ -34,6 +34,51 @@ > compatible = "simple-bus"; > interrupt-parent = <&mpic>; > > + devbus-bootcs { > + compatible = "marvell,mvebu-devbus"; > + reg = <0 0x10400 0x8>; > + #address-cells = <1>; > + #size-cells = <1>; > + clocks = <&coreclk 0>; > + status = "disabled"; > + }; > + ... > internal-regs { > compatible = "simple-bus"; > #address-cells = <1>; I think you are missing a couple of things here: * The mbus node needs #address-cells and #size-cells, and is no longer compatible="simple-bus"m since it's actually complex. * The devbus-bootcs node and all other ones need "ranges" properties. * The "reg" property of the devbus-bootcs device needs to be in mbus translated address space, so I assume the first cell would be something other than '0'. * With the proposal I made for patch 3, you would actually need a ranges property for the mbus node as well. Arnd