All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fengguang Wu <fengguang.wu@intel.com>
To: Tejun Heo <tj@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	kbuild-all@01.org, Christopher Li <sparse@chrisli.org>,
	Dan Carpenter <dan.carpenter@oracle.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: kernel/workqueue.c:4435:61: sparse: expression using sizeof bool
Date: Sat, 8 Jun 2013 07:50:03 +0800	[thread overview]
Message-ID: <20130607235003.GA7234@localhost> (raw)
In-Reply-To: <20130607220351.GE14781@mtj.dyndns.org>

On Fri, Jun 07, 2013 at 03:03:51PM -0700, Tejun Heo wrote:
> On Fri, Jun 07, 2013 at 02:15:21PM -0700, Andrew Morton wrote:
> > >   4434		/* copy worker description */
> > > > 4435		probe_kernel_read(&desc_valid, &worker->desc_valid, sizeof(desc_valid));
> > 
> > I don't understand the rationale for the sparse test, really.  This
> > code seems unproblematic.
> 
> Yeah, I've gotten that warning a couple times now and am just ignoring
> it at this point.  Maybe the standard says bool isn't a proper
> integeral type and its size isn't precisely defined or something?  I
> don't know.

Hmm, I'd better disable the warnings that are normally ignored anyway..

Thanks,
Fengguang

       reply	other threads:[~2013-06-07 23:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <51afd3ac.1kKgJcnM4PAV+Agb%fengguang.wu@intel.com>
     [not found] ` <20130607141521.4000962d5ac0d7fcd54800cf@linux-foundation.org>
     [not found]   ` <20130607220351.GE14781@mtj.dyndns.org>
2013-06-07 23:50     ` Fengguang Wu [this message]
     [not found]     ` <20130607184614.45418364.akpm@linux-foundation.org>
     [not found]       ` <20130608020549.GN14781@mtj.dyndns.org>
2013-06-08  2:15         ` kernel/workqueue.c:4435:61: sparse: expression using sizeof bool Fengguang Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130607235003.GA7234@localhost \
    --to=fengguang.wu@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=dan.carpenter@oracle.com \
    --cc=kbuild-all@01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sparse@chrisli.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.