diff for duplicates of <20130609032300.GB4312@tarshish> diff --git a/a/1.txt b/N1/1.txt index 8253288..beb325c 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -3,7 +3,7 @@ Hi Zhangfei Gao, On Sun, Jun 09, 2013 at 10:36:42AM +0800, Zhangfei Gao wrote: > Add support hisilicon i2c driver, which reuse designware i2c ip > -> Signed-off-by: Zhangfei Gao <zhangfei.gao@linaro.org> +> Signed-off-by: Zhangfei Gao <zhangfei.gao-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> > --- > .../devicetree/bindings/i2c/i2c-designware-hs.txt | 30 +++ > drivers/i2c/busses/Kconfig | 10 + @@ -29,12 +29,12 @@ On Sun, Jun 09, 2013 at 10:36:42AM +0800, Zhangfei Gao wrote: > + > +Example : > + -> + i2c0: i2c at fcb08000 { +> + i2c0: i2c@fcb08000 { > + compatible = "hs,designware-i2c"; A few comments on this one: -1. You should Cc devicetree-discuss at lists.ozlabs.org on patches touching ftd +1. You should Cc devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org on patches touching ftd bindings (added to Cc) 2. The convention is to use the IC block designer in the "compatible" property @@ -55,14 +55,14 @@ A few comments on this one: > + }; > + > + Client in i2c0 bus with add 0x58 could be added as example -> + i2c0: i2c at fcb08000 { +> + i2c0: i2c@fcb08000 { > + status = "ok"; The convention is to use "okay". > + pinctrl-names = "default"; > + pinctrl-0 = <&i2c0_pmx_func &i2c0_cfg_func>; -> + i2c_client1: i2c_client at 58 { +> + i2c_client1: i2c_client@58 { > + compatible = "hisilicon,i2c_client_tpa2028"; > + reg = <0x58>; > + }; @@ -116,4 +116,4 @@ baruch -- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il - + - baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org - tel: +972.2.679.5364, http://www.tkos.co.il - diff --git a/a/content_digest b/N1/content_digest index a49d647..a174ff5 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,9 +1,14 @@ "ref\01370745402-11844-1-git-send-email-zhangfei.gao@linaro.org\0" "ref\01370745402-11844-3-git-send-email-zhangfei.gao@linaro.org\0" - "From\0baruch@tkos.co.il (Baruch Siach)\0" - "Subject\0[PATCH 2/2] i2c: designware: Add i2c-designware-hs\0" + "ref\01370745402-11844-3-git-send-email-zhangfei.gao-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org\0" + "From\0Baruch Siach <baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org>\0" + "Subject\0Re: [PATCH 2/2] i2c: designware: Add i2c-designware-hs\0" "Date\0Sun, 9 Jun 2013 06:23:00 +0300\0" - "To\0linux-arm-kernel@lists.infradead.org\0" + "To\0Zhangfei Gao <zhangfei.gao-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>\0" + "Cc\0Dirk Brandewie <dirk.brandewie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>" + devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org + linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org + " Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>\0" "\00:1\0" "b\0" "Hi Zhangfei Gao,\n" @@ -11,7 +16,7 @@ "On Sun, Jun 09, 2013 at 10:36:42AM +0800, Zhangfei Gao wrote:\n" "> Add support hisilicon i2c driver, which reuse designware i2c ip\n" "> \n" - "> Signed-off-by: Zhangfei Gao <zhangfei.gao@linaro.org>\n" + "> Signed-off-by: Zhangfei Gao <zhangfei.gao-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>\n" "> ---\n" "> .../devicetree/bindings/i2c/i2c-designware-hs.txt | 30 +++\n" "> drivers/i2c/busses/Kconfig | 10 +\n" @@ -37,12 +42,12 @@ "> +\n" "> +Example :\n" "> +\n" - "> +\ti2c0: i2c at fcb08000 {\n" + "> +\ti2c0: i2c@fcb08000 {\n" "> +\t\tcompatible = \"hs,designware-i2c\";\n" "\n" "A few comments on this one:\n" "\n" - "1. You should Cc devicetree-discuss at lists.ozlabs.org on patches touching ftd \n" + "1. You should Cc devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org on patches touching ftd \n" " bindings (added to Cc)\n" "\n" "2. The convention is to use the IC block designer in the \"compatible\" property \n" @@ -63,14 +68,14 @@ "> +\t};\n" "> +\n" "> +\tClient in i2c0 bus with add 0x58 could be added as example\n" - "> +\ti2c0: i2c at fcb08000 {\n" + "> +\ti2c0: i2c@fcb08000 {\n" "> +\t\tstatus = \"ok\";\n" "\n" "The convention is to use \"okay\".\n" "\n" "> +\t\tpinctrl-names = \"default\";\n" "> +\t\tpinctrl-0 = <&i2c0_pmx_func &i2c0_cfg_func>;\n" - "> +\t\ti2c_client1: i2c_client at 58 {\n" + "> +\t\ti2c_client1: i2c_client@58 {\n" "> +\t\t\tcompatible = \"hisilicon,i2c_client_tpa2028\";\n" "> +\t\t\treg = <0x58>;\n" "> +\t\t};\n" @@ -124,6 +129,6 @@ "-- \n" " http://baruch.siach.name/blog/ ~. .~ Tk Open Systems\n" "=}------------------------------------------------ooO--U--Ooo------------{=\n" - - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il - + - baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org - tel: +972.2.679.5364, http://www.tkos.co.il - -66ef7b49c11bfde19bd6316e57bb5a4dd790c6f840d9ee51d7981725e67e11ee +87239196d0aa2c08d6f29b76ceb9119c1b66280b81e176bbf8ca9001d40c9758
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.