diff for duplicates of <20130609095026.GF4312@tarshish> diff --git a/a/1.txt b/N1/1.txt index 30c21d0..02ba9a0 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -13,12 +13,12 @@ On Sun, Jun 09, 2013 at 04:59:48PM +0800, zhangfei gao wrote: > >> + > >> +Example : > >> + -> >> + i2c0: i2c at fcb08000 { +> >> + i2c0: i2c@fcb08000 { > >> + compatible = "hs,designware-i2c"; > > > > A few comments on this one: > > -> > 1. You should Cc devicetree-discuss at lists.ozlabs.org on patches touching ftd +> > 1. You should Cc devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org on patches touching ftd > > bindings (added to Cc) > > > > 2. The convention is to use the IC block designer in the "compatible" property @@ -36,7 +36,7 @@ On Sun, Jun 09, 2013 at 04:59:48PM +0800, zhangfei gao wrote: I don't think this is needed. See below. > >> + Client in i2c0 bus with add 0x58 could be added as example -> >> + i2c0: i2c at fcb08000 { +> >> + i2c0: i2c@fcb08000 { > >> + status = "ok"; > > > > The convention is to use "okay". @@ -45,7 +45,7 @@ I don't think this is needed. See below. > > > >> + pinctrl-names = "default"; > >> + pinctrl-0 = <&i2c0_pmx_func &i2c0_cfg_func>; -> >> + i2c_client1: i2c_client at 58 { +> >> + i2c_client1: i2c_client@58 { > >> + compatible = "hisilicon,i2c_client_tpa2028"; > >> + reg = <0x58>; > >> + }; @@ -100,4 +100,4 @@ baruch -- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il - + - baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org - tel: +972.2.679.5364, http://www.tkos.co.il - diff --git a/a/content_digest b/N1/content_digest index e1dd260..9314927 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,10 +2,16 @@ "ref\01370745402-11844-3-git-send-email-zhangfei.gao@linaro.org\0" "ref\020130609032300.GB4312@tarshish\0" "ref\0CAMj5BkhPp_-b19WFM-XitJ5-qDd9-dETp7UdNRLkRbdcq_h-Vg@mail.gmail.com\0" - "From\0baruch@tkos.co.il (Baruch Siach)\0" - "Subject\0[PATCH 2/2] i2c: designware: Add i2c-designware-hs\0" + "ref\0CAMj5BkhPp_-b19WFM-XitJ5-qDd9-dETp7UdNRLkRbdcq_h-Vg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org\0" + "From\0Baruch Siach <baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org>\0" + "Subject\0Re: [PATCH 2/2] i2c: designware: Add i2c-designware-hs\0" "Date\0Sun, 9 Jun 2013 12:50:26 +0300\0" - "To\0linux-arm-kernel@lists.infradead.org\0" + "To\0zhangfei gao <zhangfei.gao-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>\0" + "Cc\0Dirk Brandewie <dirk.brandewie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>" + Zhangfei Gao <zhangfei.gao-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> + device-tree <devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org> + linux-arm-kernel <linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org> + " Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>\0" "\00:1\0" "b\0" "Hi zhangfei gao,\n" @@ -23,12 +29,12 @@ "> >> +\n" "> >> +Example :\n" "> >> +\n" - "> >> + i2c0: i2c at fcb08000 {\n" + "> >> + i2c0: i2c@fcb08000 {\n" "> >> + compatible = \"hs,designware-i2c\";\n" "> >\n" "> > A few comments on this one:\n" "> >\n" - "> > 1. You should Cc devicetree-discuss at lists.ozlabs.org on patches touching ftd\n" + "> > 1. You should Cc devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org on patches touching ftd\n" "> > bindings (added to Cc)\n" "> >\n" "> > 2. The convention is to use the IC block designer in the \"compatible\" property\n" @@ -46,7 +52,7 @@ "I don't think this is needed. See below.\n" "\n" "> >> + Client in i2c0 bus with add 0x58 could be added as example\n" - "> >> + i2c0: i2c at fcb08000 {\n" + "> >> + i2c0: i2c@fcb08000 {\n" "> >> + status = \"ok\";\n" "> >\n" "> > The convention is to use \"okay\".\n" @@ -55,7 +61,7 @@ "> >\n" "> >> + pinctrl-names = \"default\";\n" "> >> + pinctrl-0 = <&i2c0_pmx_func &i2c0_cfg_func>;\n" - "> >> + i2c_client1: i2c_client at 58 {\n" + "> >> + i2c_client1: i2c_client@58 {\n" "> >> + compatible = \"hisilicon,i2c_client_tpa2028\";\n" "> >> + reg = <0x58>;\n" "> >> + };\n" @@ -110,6 +116,6 @@ "-- \n" " http://baruch.siach.name/blog/ ~. .~ Tk Open Systems\n" "=}------------------------------------------------ooO--U--Ooo------------{=\n" - - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il - + - baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org - tel: +972.2.679.5364, http://www.tkos.co.il - -38fd3ee7f01da1fff9217789b8ec23e883ad4c5adee122ee9ee0d29daf8999ae +c3685fe5ca0b67b9f429304060047530d6e5532a4277aec32f8a66ff2b24df24
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.