From: Anton Vorontsov <anton@enomsg.org>
To: Kees Cook <keescook@chromium.org>
Cc: Joe Perches <joe@perches.com>,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jens Axboe <axboe@kernel.dk>,
"David S. Miller" <davem@davemloft.net>,
Herbert Xu <herbert@gondor.hengli.com.au>,
David Woodhouse <dwmw2@infradead.org>,
Karsten Keil <isdn@linux-pingi.de>,
"# 3.4.x" <stable@vger.kernel.org>
Subject: Re: [PATCH] power: Add missing newlines, fix a couple of typos, add pr_fmt
Date: Sun, 9 Jun 2013 10:10:48 -0700 [thread overview]
Message-ID: <20130609171047.GB23128@teo> (raw)
In-Reply-To: <CAGXu5j+YwLHzETz4kkSFU0bJRWgR44qtypc8vDGJX5tvhm1khw@mail.gmail.com>
On Fri, Jun 07, 2013 at 11:31:06AM -0700, Kees Cook wrote:
> On Thu, Jun 6, 2013 at 6:25 PM, Joe Perches <joe@perches.com> wrote:
> > Make sure that dev_<level> calls are newline terminated.
> > Add #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt to prefix
> > all pr_<level> calls with "charger-manager: "
> >
> > Fix a couple of typos.
> > Fix formats with terminating n that should be \n.
> > Coalesce formats for easier grep.
> > Align arguments to open parenthesis for these dev_<level> calls.
> > Add missing spaces after coalescing multiple string segments.
> >
> > Signed-off-by: Joe Perches <joe@perches.com>
>
> Looks like good clean-ups.
>
> Acked-by: Kees Cook <keescook@chromium.org>
Applied, thanks!
Anton
next prev parent reply other threads:[~2013-06-09 17:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-06 20:52 [PATCH 0/8] format string usage clean ups Kees Cook
2013-06-06 20:52 ` [PATCH 1/8] block: do not pass disk names as format strings Kees Cook
2013-06-06 20:52 ` [PATCH 2/8] kobject: sanitize argument for format string Kees Cook
2013-06-06 20:52 ` [PATCH 3/8] crypto: " Kees Cook
2013-06-06 20:52 ` [PATCH 4/8] power: ensure event is not used as " Kees Cook
2013-06-07 0:39 ` Anton Vorontsov
2013-06-07 1:25 ` [PATCH] power: Add missing newlines, fix a couple of typos, add pr_fmt Joe Perches
2013-06-07 18:31 ` Kees Cook
2013-06-09 17:10 ` Anton Vorontsov [this message]
2013-06-06 20:52 ` [PATCH 5/8] device: avoid format string in dev_set_name Kees Cook
2013-06-07 23:10 ` Greg Kroah-Hartman
2013-06-06 20:52 ` [PATCH 6/8] workqueue: avoid format strings in names Kees Cook
2013-06-06 20:52 ` [PATCH 7/8] kthread: avoid parsing names as format strings Kees Cook
2013-06-06 20:52 ` [PATCH 8/8] isdn: clean up debug format string usage Kees Cook
2013-06-07 18:32 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130609171047.GB23128@teo \
--to=anton@enomsg.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=davem@davemloft.net \
--cc=dwmw2@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=herbert@gondor.hengli.com.au \
--cc=isdn@linux-pingi.de \
--cc=joe@perches.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.