From: Emil Goode <emilgoode@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: artem.bityutskiy@linux.intel.com,
Andy Shevchenko <andy.shevchenko@gmail.com>,
linux-mtd@lists.infradead.org
Subject: Re: [PATCH] mtd: orion_nand: convert printk to dev_*
Date: Mon, 10 Jun 2013 00:39:20 +0200 [thread overview]
Message-ID: <20130609223920.GA3963@debian> (raw)
In-Reply-To: <20130609221808.GY23987@mwanda>
Hello Dan,
Thank you for pointing this out, I was going to send a second version
and fix that typo anyway so I will send a patch that applies on top
of Andy's patch and also remove that error message for kzalloc.
Best regards,
Emil
On Mon, Jun 10, 2013 at 01:18:08AM +0300, Dan Carpenter wrote:
> On Mon, Jun 10, 2013 at 12:16:54AM +0300, Andy Shevchenko wrote:
> > It's better to use actual device name as a prefix in error messages.
> >
>
> Gar...
>
> This doesn't apply on top of Emil's patch. Emil's patch was first
> so it should go in first. Also Emil's patch was a bugfix so it is
> more important than this printk cleanup patch.
>
> Really, the kzalloc error messages should just be deleted. They are
> cargo cult error messages as in "we need an error message because
> we are copy and pasting from other code without thinking." Kzalloc
> already has far better messages built in.
>
> Ah well...
>
> regards,
> dan carpenter
prev parent reply other threads:[~2013-06-09 22:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-09 21:16 [PATCH] mtd: orion_nand: convert printk to dev_* Andy Shevchenko
2013-06-09 22:18 ` Dan Carpenter
2013-06-09 22:31 ` Andy Shevchenko
2013-06-09 23:34 ` Emil Goode
2013-06-09 22:39 ` Emil Goode [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130609223920.GA3963@debian \
--to=emilgoode@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=artem.bityutskiy@linux.intel.com \
--cc=dan.carpenter@oracle.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.