Re: [PATCH v2] i2c: core: make it possible to match a pure device tree driver

[Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1257 bytes --]

On Mon, Jun 10, 2013 at 02:18:17PM +0200, Linus Walleij wrote:
> On Fri, Jun 7, 2013 at 11:32 PM, Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org> wrote:
> > ...
> >> I2C devices probed from device tree should subsequently be
> >> fixed to handle the case where of_match_table() is
> >> used (I think none of them do that today), and platforms should
> >> fix their device trees to use compatible strings for I2C devices
> >> instead of setting the name to Linux device driver names as is
> >> done in multiple cases today.
> >
> > I guess your solution is the least intrusive one. Still, it could happen
> > that of_match_table is scanned three times (by driver core, i2c layer,
> > and i2c driver) which is IMO an indication to look for a more elegant
> > solution tp find out what really matched?
> 
> I think that is a generic problem with the device tree
> being completely stateless, and rather a comment on the
> of_match_device() intrinsics being inelegant than on this
> patch?

Yes.

> Do you see it as a blocker for the patch?

No blocker. Yet, I was hoping for somebody perhaps having a good idea.
Platform devices have 'id_entry', for example. Sadly, I don't have the
resources to pick up a similar idea.


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]