From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Phil Oester <kernel@linuxace.com>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] Remove redundant TCP header checks from xt_TCPOPTSTRIP
Date: Mon, 10 Jun 2013 22:22:57 +0200 [thread overview]
Message-ID: <20130610202257.GJ14637@breakpoint.cc> (raw)
In-Reply-To: <20130610181516.GA3757@localhost>
Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> We cannot assume nf_conntrack is loaded. We have to support stateless
> setups as well.
>
> > In addition, there was an error in the check which was added (len
> > is being calculated incorrectly). In my testing, ALL packets are being dropped
> > by the TCPOPTSTRIP target at present. Revert the unnecessary/incorrect checks.
>
> Then, we have to fix the wrong calculation. I cannot reproduce this
> here.
Its most likely due to tcp_hdr() use, it only works for local packets.
prev parent reply other threads:[~2013-06-10 20:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-10 3:59 [PATCH] Remove redundant TCP header checks from xt_TCPOPTSTRIP Phil Oester
2013-06-10 18:15 ` Pablo Neira Ayuso
2013-06-10 20:22 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130610202257.GJ14637@breakpoint.cc \
--to=fw@strlen.de \
--cc=kernel@linuxace.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.