From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH 2/2] memory: tegra30-mc: Fix IRQ handler bugs. Date: Mon, 10 Jun 2013 22:37:49 +0200 Message-ID: <20130610203748.GB26036@mithrandir> References: <1370855624-30564-1-git-send-email-ttynkkynen@nvidia.com> <1370855624-30564-3-git-send-email-ttynkkynen@nvidia.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="E39vaYmALEf/7YXx" Return-path: Content-Disposition: inline In-Reply-To: <1370855624-30564-3-git-send-email-ttynkkynen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Tuomas Tynkkynen Cc: gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-tegra@vger.kernel.org --E39vaYmALEf/7YXx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jun 10, 2013 at 12:13:44PM +0300, Tuomas Tynkkynen wrote: [...] > diff --git a/drivers/memory/tegra30-mc.c b/drivers/memory/tegra30-mc.c [...] > @@ -313,8 +313,11 @@ static irqreturn_t tegra30_mc_isr(int irq, void *data) > mask &= stat; > if (!mask) > return IRQ_NONE; > - while ((bit = ffs(mask)) != 0) > + while ((bit = ffs(mask)) != 0) { > tegra30_mc_decode(mc, bit - 1); > + mask &= BIT(bit); Same comment as for patch 1/2. Thierry --E39vaYmALEf/7YXx Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (GNU/Linux) iQIcBAEBAgAGBQJRtjkcAAoJEN0jrNd/PrOhJTQP/jxuMESlkis/fkdlwjVZuHQf 7iZ9k7qQhWCXViAiwBwnWxRcSRBFm9yFD32gZwmppXxxRgKi8pqc/kVnNVud5cys isEp3avTptGlIRBooYCC6srKUEWJlPQq6TiwBP8TBVXgsHsro8XaNWYS0GHYlgFD NRMw3hrTW+rLfzbTxPgOhxe3Eehq9w9W2mWya+d0rkiHp/qm+sJJrvX9t8be7Y9i e0RMPB84gIWpZ3fhGsln0bxSYqoevBBralAcKXVohosvwhYD3cxe6Ks/5H31wxOY T2vC0QuHEpo8VFODZW/t+ndAvjQr7Vtw+1YAL3kQmFR6gaDPpNAFTrBRU/oqVWws b14p3n/juNb9Is/ayfv0vDOFkQ8OKvaOWS+XvmL/CW0Sjxwmal5hfn3wxm/HH1s4 tmtvTkLSFFjGoMiN3enDqe+61gazBxP4h6lseYmbqN9REHCn0r6JGFzLkzROgcZr /a+vV02H7txBtjNBxacH5vBsGVRa+q1aipiRa5ctNktF60hFCZeZUo/lVfCKNNT1 KHcPGd2fKBMoZohT5ZPI+3l75UWusWsdF3BUHOCpG2+ejvPG62eropdcLnbUQwVQ vJ9KCWTd9rID02kk4FeCQqrhsLvhPj51zxoWoTEZgmiq9rZowRdLihToY9rY6anT 6eEzbTwJIT1pJFgGYP2u =vKey -----END PGP SIGNATURE----- --E39vaYmALEf/7YXx-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: thierry.reding@gmail.com (Thierry Reding) Date: Mon, 10 Jun 2013 22:37:49 +0200 Subject: [PATCH 2/2] memory: tegra30-mc: Fix IRQ handler bugs. In-Reply-To: <1370855624-30564-3-git-send-email-ttynkkynen@nvidia.com> References: <1370855624-30564-1-git-send-email-ttynkkynen@nvidia.com> <1370855624-30564-3-git-send-email-ttynkkynen@nvidia.com> Message-ID: <20130610203748.GB26036@mithrandir> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Jun 10, 2013 at 12:13:44PM +0300, Tuomas Tynkkynen wrote: [...] > diff --git a/drivers/memory/tegra30-mc.c b/drivers/memory/tegra30-mc.c [...] > @@ -313,8 +313,11 @@ static irqreturn_t tegra30_mc_isr(int irq, void *data) > mask &= stat; > if (!mask) > return IRQ_NONE; > - while ((bit = ffs(mask)) != 0) > + while ((bit = ffs(mask)) != 0) { > tegra30_mc_decode(mc, bit - 1); > + mask &= BIT(bit); Same comment as for patch 1/2. Thierry -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: not available URL: From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753154Ab3FJUhx (ORCPT ); Mon, 10 Jun 2013 16:37:53 -0400 Received: from mail-bk0-f48.google.com ([209.85.214.48]:49368 "EHLO mail-bk0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752177Ab3FJUhw (ORCPT ); Mon, 10 Jun 2013 16:37:52 -0400 Date: Mon, 10 Jun 2013 22:37:49 +0200 From: Thierry Reding To: Tuomas Tynkkynen Cc: gregkh@linuxfoundation.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] memory: tegra30-mc: Fix IRQ handler bugs. Message-ID: <20130610203748.GB26036@mithrandir> References: <1370855624-30564-1-git-send-email-ttynkkynen@nvidia.com> <1370855624-30564-3-git-send-email-ttynkkynen@nvidia.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="E39vaYmALEf/7YXx" Content-Disposition: inline In-Reply-To: <1370855624-30564-3-git-send-email-ttynkkynen@nvidia.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --E39vaYmALEf/7YXx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jun 10, 2013 at 12:13:44PM +0300, Tuomas Tynkkynen wrote: [...] > diff --git a/drivers/memory/tegra30-mc.c b/drivers/memory/tegra30-mc.c [...] > @@ -313,8 +313,11 @@ static irqreturn_t tegra30_mc_isr(int irq, void *data) > mask &= stat; > if (!mask) > return IRQ_NONE; > - while ((bit = ffs(mask)) != 0) > + while ((bit = ffs(mask)) != 0) { > tegra30_mc_decode(mc, bit - 1); > + mask &= BIT(bit); Same comment as for patch 1/2. Thierry --E39vaYmALEf/7YXx Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (GNU/Linux) iQIcBAEBAgAGBQJRtjkcAAoJEN0jrNd/PrOhJTQP/jxuMESlkis/fkdlwjVZuHQf 7iZ9k7qQhWCXViAiwBwnWxRcSRBFm9yFD32gZwmppXxxRgKi8pqc/kVnNVud5cys isEp3avTptGlIRBooYCC6srKUEWJlPQq6TiwBP8TBVXgsHsro8XaNWYS0GHYlgFD NRMw3hrTW+rLfzbTxPgOhxe3Eehq9w9W2mWya+d0rkiHp/qm+sJJrvX9t8be7Y9i e0RMPB84gIWpZ3fhGsln0bxSYqoevBBralAcKXVohosvwhYD3cxe6Ks/5H31wxOY T2vC0QuHEpo8VFODZW/t+ndAvjQr7Vtw+1YAL3kQmFR6gaDPpNAFTrBRU/oqVWws b14p3n/juNb9Is/ayfv0vDOFkQ8OKvaOWS+XvmL/CW0Sjxwmal5hfn3wxm/HH1s4 tmtvTkLSFFjGoMiN3enDqe+61gazBxP4h6lseYmbqN9REHCn0r6JGFzLkzROgcZr /a+vV02H7txBtjNBxacH5vBsGVRa+q1aipiRa5ctNktF60hFCZeZUo/lVfCKNNT1 KHcPGd2fKBMoZohT5ZPI+3l75UWusWsdF3BUHOCpG2+ejvPG62eropdcLnbUQwVQ vJ9KCWTd9rID02kk4FeCQqrhsLvhPj51zxoWoTEZgmiq9rZowRdLihToY9rY6anT 6eEzbTwJIT1pJFgGYP2u =vKey -----END PGP SIGNATURE----- --E39vaYmALEf/7YXx--