From: Andrew Morton <akpm@linux-foundation.org>
To: ebiederm@xmission.com (Eric W. Biederman)
Cc: "Raphael S. Carvalho" <raphael.scarv@gmail.com>,
"Serge E. Hallyn" <serge@hallyn.com>,
Serge Hallyn <serge.hallyn@canonical.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] kernel/pid.c: Masking the flag out to get the actual value.
Date: Tue, 11 Jun 2013 18:28:31 -0700 [thread overview]
Message-ID: <20130611182831.8d6d25be.akpm@linux-foundation.org> (raw)
In-Reply-To: <8761xkt9fh.fsf@xmission.com>
On Tue, 11 Jun 2013 18:16:50 -0700 ebiederm@xmission.com (Eric W. Biederman) wrote:
>
> > Hopefully we can fix this one by adding the missing comment.
>
> Perhaps we can fix this one by having people who care read the code and
> think about what it means?
As is obvious from this thread, that approach isn't working.
> Seriously if we are adding pids/processes in
> the pid namespace why would to clean up the pid namespace?
A good way to communicate the design would be to describe the semantics
of PIDNS_HASH_ADDING, at its definition site.
[idly wonders what the heck pid_namespace.level and pid.level do, sigh]
next prev parent reply other threads:[~2013-06-12 1:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-10 21:56 [PATCH 1/1] kernel/pid.c: Masking the flag out to get the actual value Raphael S. Carvalho
2013-06-11 22:45 ` Andrew Morton
2013-06-12 1:16 ` Eric W. Biederman
2013-06-12 1:28 ` Andrew Morton [this message]
2013-06-12 1:53 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130611182831.8d6d25be.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=raphael.scarv@gmail.com \
--cc=serge.hallyn@canonical.com \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.