Re: [Qemu-devel] [Qemu-stable] [PATCH 3/3] savevm: avoid leaking popen(3) file pointer

[mdroth <mdroth@linux.vnet.ibm.com>]

On Thu, May 30, 2013 at 04:14:46PM +0200, Stefan Hajnoczi wrote:
> I'm not sure why we check the mode only after invoking popen(3) but we
> need to close the file pointer.
> 
> Spotted by Coverity.
> 
> Cc: Juan Quintela <quintela@redhat.com>
> Cc: qemu-stable@nongnu.org
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>

Ping, looking to get this in for 1.5.1

> ---
>  savevm.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/savevm.c b/savevm.c
> index 31dcce9..75cc72e 100644
> --- a/savevm.c
> +++ b/savevm.c
> @@ -329,6 +329,7 @@ QEMUFile *qemu_popen_cmd(const char *command, const char *mode)
> 
>      if (mode == NULL || (mode[0] != 'r' && mode[0] != 'w') || mode[1] != 0) {
>          fprintf(stderr, "qemu_popen: Argument validity check failed\n");
> +        fclose(stdio_file);
>          return NULL;
>      }
> 
> -- 
> 1.8.1.4
> 
>