From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vinod Koul Subject: Re: [PATCH 2/9] dma: pl330: use dma_addr_t for describing bus addresses Date: Wed, 12 Jun 2013 11:01:54 +0530 Message-ID: <20130612053154.GE4107@intel.com> References: <1370889285-22799-1-git-send-email-will.deacon@arm.com> <1370889285-22799-3-git-send-email-will.deacon@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Jassi Brar Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Will Deacon , device-tree , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" List-Id: iommu@lists.linux-foundation.org T24gVHVlLCBKdW4gMTEsIDIwMTMgYXQgMTA6MDc6MTJBTSArMDUzMCwgSmFzc2kgQnJhciB3cm90 ZToKPiBPbiAxMSBKdW5lIDIwMTMgMDA6MDQsIFdpbGwgRGVhY29uIDx3aWxsLmRlYWNvbkBhcm0u Y29tPiB3cm90ZToKPiAKPiA+IFRoZSBtaWNyb2NvZGUgYnVzIGFkZHJlc3MgKHBsMzMwX2RtYWMu bWNvZGVfYnVzKSBpcyBjdXJyZW50bHkgYSB1MzIsCj4gPiB3aGljaCBmYWlscyB0byBjb21waWxl IHdoZW4gYnVpbGRpbmcgb24gYSBzeXN0ZW0gd2l0aCA2NC1iaXQgYnVzCj4gPiBhZGRyZXNzZXMu Cj4gPgo+ID4gVGhpcyBwYXRjaCB1c2VzIGRtYV9hZGRyX3QgdG8gcmVwcmVzZW50IHRoZSBhZGRy ZXNzIGluc3RlYWQuCj4gPgo+ID4gQWNrZWQtYnk6IEphc3NpIEJyYXIgPGphc3dpbmRlci5zaW5n aEBsaW5hcm8ub3JnPgo+IAo+IAo+ID4gQ2M6IEphc3NpIEJyYXIgPGphc3dpbmRlci5zaW5naEBs aW5hcm8ub3JnPgo+ID4gQ2M6IFZpbm9kIEtvdWwgPHZpbm9kLmtvdWxAaW50ZWwuY29tPgo+ID4g U2lnbmVkLW9mZi1ieTogV2lsbCBEZWFjb24gPHdpbGwuZGVhY29uQGFybS5jb20+CkFwcGxpZWQs IHRoYW5rcwoKLS0KflZpbm9kCj4gPiAtLS0KPiA+ICBkcml2ZXJzL2RtYS9wbDMzMC5jIHwgMiAr LQo+ID4gIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQo+ID4K PiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2RtYS9wbDMzMC5jIGIvZHJpdmVycy9kbWEvcGwzMzAu Ywo+ID4gaW5kZXggMjJlMmE4Zi4uZjFiYzU5MyAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZG1h L3BsMzMwLmMKPiA+ICsrKyBiL2RyaXZlcnMvZG1hL3BsMzMwLmMKPiA+IEBAIC01MDEsNyArNTAx LDcgQEAgc3RydWN0IHBsMzMwX2RtYWMgewo+ID4gICAgICAgICAvKiBNYXhpbXVtIHBvc3NpYmxl IGV2ZW50cy9pcnFzICovCj4gPiAgICAgICAgIGludCAgICAgICAgICAgICAgICAgICAgIGV2ZW50 c1szMl07Cj4gPiAgICAgICAgIC8qIEJVUyBhZGRyZXNzIG9mIE1pY3JvQ29kZSBidWZmZXIgKi8K PiA+IC0gICAgICAgdTMyICAgICAgICAgICAgICAgICAgICAgbWNvZGVfYnVzOwo+ID4gKyAgICAg ICBkbWFfYWRkcl90ICAgICAgICAgICAgICBtY29kZV9idXM7Cj4gPiAgICAgICAgIC8qIENQVSBh ZGRyZXNzIG9mIE1pY3JvQ29kZSBidWZmZXIgKi8KPiA+ICAgICAgICAgdm9pZCAgICAgICAgICAg ICAgICAgICAgKm1jb2RlX2NwdTsKPiA+ICAgICAgICAgLyogTGlzdCBvZiBhbGwgQ2hhbm5lbCB0 aHJlYWRzICovCj4gPiAtLQo+ID4gMS44LjIuMgo+ID4KPiA+Cj4gCj4gCj4gLS0gCj4gTGluYXJv Lm9yZyDilIIgT3BlbiBzb3VyY2Ugc29mdHdhcmUgZm9yIEFSTSBTb0NzIHwgRm9sbG93IExpbmFy bwo+IGh0dHA6Ly9mYWNlYm9vay5jb20vcGFnZXMvTGluYXJvLzE1NTk3NDU4MTA5MTEwNiAgLQo+ IGh0dHA6Ly90d2l0dGVyLmNvbS8jIS9saW5hcm9vcmcgLSBodHRwOi8vbGluYXJvLm9yZy9saW5h cm8tYmxvZwoKLS0gCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmRldmljZXRyZWUtZGlzY3VzcyBtYWlsaW5nIGxpc3QKZGV2aWNldHJlZS1kaXNjdXNzQGxp c3RzLm96bGFicy5vcmcKaHR0cHM6Ly9saXN0cy5vemxhYnMub3JnL2xpc3RpbmZvL2RldmljZXRy ZWUtZGlzY3Vzcwo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: vinod.koul@intel.com (Vinod Koul) Date: Wed, 12 Jun 2013 11:01:54 +0530 Subject: [PATCH 2/9] dma: pl330: use dma_addr_t for describing bus addresses In-Reply-To: References: <1370889285-22799-1-git-send-email-will.deacon@arm.com> <1370889285-22799-3-git-send-email-will.deacon@arm.com> Message-ID: <20130612053154.GE4107@intel.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Jun 11, 2013 at 10:07:12AM +0530, Jassi Brar wrote: > On 11 June 2013 00:04, Will Deacon wrote: > > > The microcode bus address (pl330_dmac.mcode_bus) is currently a u32, > > which fails to compile when building on a system with 64-bit bus > > addresses. > > > > This patch uses dma_addr_t to represent the address instead. > > > > Acked-by: Jassi Brar > > > > Cc: Jassi Brar > > Cc: Vinod Koul > > Signed-off-by: Will Deacon Applied, thanks -- ~Vinod > > --- > > drivers/dma/pl330.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c > > index 22e2a8f..f1bc593 100644 > > --- a/drivers/dma/pl330.c > > +++ b/drivers/dma/pl330.c > > @@ -501,7 +501,7 @@ struct pl330_dmac { > > /* Maximum possible events/irqs */ > > int events[32]; > > /* BUS address of MicroCode buffer */ > > - u32 mcode_bus; > > + dma_addr_t mcode_bus; > > /* CPU address of MicroCode buffer */ > > void *mcode_cpu; > > /* List of all Channel threads */ > > -- > > 1.8.2.2 > > > > > > > -- > Linaro.org ? Open source software for ARM SoCs | Follow Linaro > http://facebook.com/pages/Linaro/155974581091106 - > http://twitter.com/#!/linaroorg - http://linaro.org/linaro-blog --