From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH 0/3] DMA fixes for ux500 ASoC driver Date: Wed, 12 Jun 2013 11:48:52 +0100 Message-ID: <20130612104852.GD4320@laptop> References: <1371023879-21884-1-git-send-email-fabio.baltieri@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-bk0-f48.google.com (mail-bk0-f48.google.com [209.85.214.48]) by alsa0.perex.cz (Postfix) with ESMTP id D1DB42615A6 for ; Wed, 12 Jun 2013 12:48:57 +0200 (CEST) Received: by mail-bk0-f48.google.com with SMTP id jf17so4429129bkc.7 for ; Wed, 12 Jun 2013 03:48:57 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1371023879-21884-1-git-send-email-fabio.baltieri@linaro.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Fabio Baltieri Cc: Ola Lilja , alsa-devel@alsa-project.org, Linus Walleij , Liam Girdwood , linux-kernel@vger.kernel.org, Mark Brown List-Id: alsa-devel@alsa-project.org T24gV2VkLCAxMiBKdW4gMjAxMywgRmFiaW8gQmFsdGllcmkgd3JvdGU6Cgo+IEhpIE1hcmssCj4g Cj4gVGhlIERNQSBkcml2ZXIgdXNlZCBvbiB1eDUwMCBoYXMgYmVlbiByZWNlbnRseSByZXdvcmtl ZCB0byBtYWtlIGl0Cj4gZGV2aWNlLXRyZWUgY2FwYWJsZSwgYnV0IHRoZSByZXdvcmsgcmVxdWly ZWQgdG8gZHJvcCBzb21lICJmZWF0dXJlcyIsCj4gc3VjaCBhcyBvcHBvcnR1bmlzdGljIGNoYW5u ZWwgYWxsb2NhdGlvbiBhbmQgaGFyZGNvZGVkIGFkZHJlc3NlcywgdGhhdAo+IHRoZSBBU29DIGRy aXZlciB3YXMgcmVseWluZyB1cG9uLgo+IAo+IFRoaXMgc2VyaWVzIGZpeGVzIHRoZSBhdWRpbyBk cml2ZXIgdG8gbWFrZSBpdCB3b3JrIHdpdGggdGhlIGN1cnJlbnQKPiBkbWE0MCBpbXBsZW1lbnRh dGlvbiwgYW5kIHdvcmtzIGZpbmUgZXZlbiB3aGVuIGJvb3Rpbmcgd2l0aCBkZXZpY2UtdHJlZS4K PiAKPiBXb3VsZCB5b3UgY29uc2lkZXIgbWVyZ2luZyB0aGVzZSBmb3IgYXNvYy90b3BpYy91eDUw MD8KPiAKPiBUaGFua3MsCj4gRmFiaW8KPiAKPiAKPiBGYWJpbyBCYWx0aWVyaSAoMyk6Cj4gICBB U29DOiB1eDUwMDogTW92ZSBETUEgcGFyYW1ldGVycyBpbnRvIHV4NTAwX21zcAo+ICAgQVNvQzog dXg1MDA6IFNldCBETUEgYWRkcmVzcyBkdXJpbmcgZGV2aWNlIGluaXQKPiAgIEFTb0M6IHV4NTAw OiBBZGQgRE1BIHNsYXZlIGNvbmZpZyBwcmVwYXJlIHJvdXRpbmUKPiAKPiAgc291bmQvc29jL3V4 NTAwL3V4NTAwX21zcF9kYWkuYyB8IDExICsrKystLS0tLS0tCj4gIHNvdW5kL3NvYy91eDUwMC91 eDUwMF9tc3BfZGFpLmggfCAgMiAtLQo+ICBzb3VuZC9zb2MvdXg1MDAvdXg1MDBfbXNwX2kycy5j IHwgMTMgKysrKysrKysrLS0tLQo+ICBzb3VuZC9zb2MvdXg1MDAvdXg1MDBfbXNwX2kycy5oIHwg MTUgKysrKysrKystLS0tLS0tCj4gIHNvdW5kL3NvYy91eDUwMC91eDUwMF9wY20uYyAgICAgfCAz MCArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKPiAgNSBmaWxlcyBjaGFuZ2VkLCA1MSBp bnNlcnRpb25zKCspLCAyMCBkZWxldGlvbnMoLSkKCkkgZG9uJ3Qgc2VlIGFueXRoaW5nIHZpc3Vh bGx5IHdyb25nIHdpdGggdGhlbSwgc28gYXMgbG9uZyBhcyB0aGV5IHdvcmsKZm9yIHlvdSwgdGhl biB5b3UgY2FuIGFwcGx5IG15OgoKQWNrZWQtYnk6IExlZSBKb25lcyA8bGVlLmpvbmVzQGxpbmFy by5vcmc+CgotLSAKTGVlIEpvbmVzCkxpbmFybyBTVC1Fcmljc3NvbiBMYW5kaW5nIFRlYW0gTGVh ZApMaW5hcm8ub3JnIOKUgiBPcGVuIHNvdXJjZSBzb2Z0d2FyZSBmb3IgQVJNIFNvQ3MKRm9sbG93 IExpbmFybzogRmFjZWJvb2sgfCBUd2l0dGVyIHwgQmxvZwpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpBbHNhLWRldmVsIG1haWxpbmcgbGlzdApBbHNhLWRl dmVsQGFsc2EtcHJvamVjdC5vcmcKaHR0cDovL21haWxtYW4uYWxzYS1wcm9qZWN0Lm9yZy9tYWls bWFuL2xpc3RpbmZvL2Fsc2EtZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756144Ab3FLKtT (ORCPT ); Wed, 12 Jun 2013 06:49:19 -0400 Received: from mail-bk0-f46.google.com ([209.85.214.46]:33121 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751588Ab3FLKs7 (ORCPT ); Wed, 12 Jun 2013 06:48:59 -0400 Date: Wed, 12 Jun 2013 11:48:52 +0100 From: Lee Jones To: Fabio Baltieri Cc: Mark Brown , Liam Girdwood , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Linus Walleij , Ola Lilja Subject: Re: [PATCH 0/3] DMA fixes for ux500 ASoC driver Message-ID: <20130612104852.GD4320@laptop> References: <1371023879-21884-1-git-send-email-fabio.baltieri@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1371023879-21884-1-git-send-email-fabio.baltieri@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 12 Jun 2013, Fabio Baltieri wrote: > Hi Mark, > > The DMA driver used on ux500 has been recently reworked to make it > device-tree capable, but the rework required to drop some "features", > such as opportunistic channel allocation and hardcoded addresses, that > the ASoC driver was relying upon. > > This series fixes the audio driver to make it work with the current > dma40 implementation, and works fine even when booting with device-tree. > > Would you consider merging these for asoc/topic/ux500? > > Thanks, > Fabio > > > Fabio Baltieri (3): > ASoC: ux500: Move DMA parameters into ux500_msp > ASoC: ux500: Set DMA address during device init > ASoC: ux500: Add DMA slave config prepare routine > > sound/soc/ux500/ux500_msp_dai.c | 11 ++++------- > sound/soc/ux500/ux500_msp_dai.h | 2 -- > sound/soc/ux500/ux500_msp_i2s.c | 13 +++++++++---- > sound/soc/ux500/ux500_msp_i2s.h | 15 ++++++++------- > sound/soc/ux500/ux500_pcm.c | 30 ++++++++++++++++++++++++++++++ > 5 files changed, 51 insertions(+), 20 deletions(-) I don't see anything visually wrong with them, so as long as they work for you, then you can apply my: Acked-by: Lee Jones -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog