From mboxrd@z Thu Jan 1 00:00:00 1970 From: Damien Lespiau Subject: Re: [PATCH 9/9] drm/i915: check for strange pfit pipe assignemnt on ivb/hsw Date: Wed, 12 Jun 2013 14:03:50 +0100 Message-ID: <20130612130350.GA15338@strange.amr.corp.intel.com> References: <1369166099-1840-1-git-send-email-daniel.vetter@ffwll.ch> <1369166099-1840-10-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by gabe.freedesktop.org (Postfix) with ESMTP id 747AFE5BF9 for ; Wed, 12 Jun 2013 06:03:52 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1369166099-1840-10-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: Intel Graphics Development , Mika Kuoppala List-Id: intel-gfx@lists.freedesktop.org On Tue, May 21, 2013 at 09:54:59PM +0200, Daniel Vetter wrote: > Panel fitters on ivb/hsw are not created equal since not all of them > support the new high-quality upscaling mode. To offset this the hw > allows us to freely assign the pfits to pipes. > > Since our code currently doesn't support this we might fall over when > taking over firmware state. So check for this case and WARN about it. > We can then improve the code once we've hit this in the wild. Or once > we decide to support the improved upscale modes, though that requires > global arbitrage of modeset resources across crtcs. > > Suggested-by: Mika Kuoppala > Cc: Mika Kuoppala > Signed-off-by: Daniel Vetter This is already in with a IS_GEN7() -- Damien