All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Voltz <andy.voltz@timesys.com>
To: Khem Raj <raj.khem@gmail.com>
Cc: "openembedded-core@lists.openembedded.org"
	<openembedded-core@lists.openembedded.org>,
	"openembedded-commits@lists.openembedded.org"
	<openembedded-commits@lists.openembedded.org>
Subject: Re: [oe-commits] Andy Voltz : tune-cortexa.inc: create a common include for cortex-a armv7a tuning
Date: Wed, 12 Jun 2013 12:13:56 -0400	[thread overview]
Message-ID: <20130612161355.GG17357@timesys.com> (raw)
In-Reply-To: <CAMKF1srJ1-dzfa3AhrEAJRiNG3krvBoJy78sLbc+me8YExK16A@mail.gmail.com>

Hi Khem,

> On Tue, Jun 11, 2013 at 6:45 AM, Andy Voltz <andy.voltz@timesys.com> wrote:
> > I understand that. I sent an updated patch which reverts to mtune, but I'm getting
> 
> mtune/march is small issue with this patch. I would recommend to send
> a revert of the patches
> since all arm architectures are broken as of now in OE-Core

I see the issue now. It seems that overriding the tunes with a variable
reference does not work for all the tunings. With the tune test script, I'm
seeing that these tunes are broken:
log.fake-cortexa9.cortexa9*
log.fake-cortexa8.cortexa8*

I see that variables can be assigned with a reference based on stuff like 
FILES_${QT_BASE_NAME}-fonts = ...

(From recipes-qt/qt4/qt4-embedded.inc)

I'm not sure why it works there and not in the tunings, or how to fix.

For now I have a revert patch which removes tune-cortexa.inc and restores the
previous contents of the a7,a8,a9,15 tuning files. 

It also adds the tune-cortexa5.inc file I had sent on the list originally
which led to this code-reduction experiment. That thread is here for reference:

http://lists.openembedded.org/pipermail/openembedded-core/2013-June/079452.html

Thanks for pointing out this issue. Patch is on the way.

Regards
-- 
Andy Voltz
Timesys Corporation


  reply	other threads:[~2013-06-12 16:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20130607154357.606025038F@opal>
2013-06-08  9:10 ` [oe-commits] Andy Voltz : tune-cortexa.inc: create a common include for cortex-a armv7a tuning Martin Jansa
2013-06-08  9:15   ` Martin Jansa
2013-06-10 15:50     ` Andy Voltz
2013-06-11  4:12       ` Khem Raj
2013-06-11 13:45         ` Andy Voltz
2013-06-11 15:01           ` Khem Raj
2013-06-12 16:13             ` Andy Voltz [this message]
2013-06-12 16:17               ` Khem Raj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130612161355.GG17357@timesys.com \
    --to=andy.voltz@timesys.com \
    --cc=openembedded-commits@lists.openembedded.org \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=raj.khem@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.