All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Chris Rankin <rankincj@yahoo.com>
Cc: "Frank Schäfer" <fschaefer.oss@googlemail.com>,
	"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>
Subject: Re: 3.9.2 kernel - IR / em28xx_rc broken?
Date: Thu, 13 Jun 2013 07:50:37 -0300	[thread overview]
Message-ID: <20130613075037.0da24c13@redhat.com> (raw)
In-Reply-To: <1369054869.78400.YahooMailNeo@web120305.mail.ne1.yahoo.com>

Em Mon, 20 May 2013 06:01:09 -0700 (PDT)
Chris Rankin <rankincj@yahoo.com> escreveu:

> ----- Original Message -----
> 
> >> And this is me calling ir-keytable:
> >>
> >> [ 2183.812407] em28xx #0: Changing protocol: rc_type=1
> 
> > So with 3.8 the same happens as with 3.9.
> 
> Yes, that does appear to be part of the RC core ABI.
> 
> > Well, if ir-keycode / the RC core requests RC_BIT_UNKNOWN, they get RC_BIT_UNKNOWN. ;)
> > If you expect the device to be configured for another protocol (RC5 ?),
> > you need to find out what's going wrong in the RC core and/or ir-keycode.
> 
> Are other RCs affected by this? I have difficulty blaming RC core when its behaviour hasn't changed.
> 
> > The point is that 3.8 ignores rc_type=1, whereas 3.9 uses it to update a new ir->rc_type field - which in turn controls how em2874_polling_getkey() encodes its scancode.

There's something broken at either the tool or at the table, as
the it shouldn't be passing rc_type=1.

Ah, I know what's happening... thare are actually two hauppauge tables:

$ grep haupp rc_maps.cfg 
# cx8800	*				./keycodes/rc5_hauppauge_new
# *		*				./keycodes/rc5_hauppauge_new
*	rc-hauppauge             hauppauge
# *	*			 haupp                # found in nova-t-usb2.c

The proper one is the "hauppauge" one. The "haupp" table is an
alternative (broken) one for a driver that was not properly
converted to the RC core yet. On that driver, the table is coded
directly inside the driver. It shouldn't be hard to fix it there,
but that requires someone with that hardware, in order to test it,
and convert it to use dvb-usb-v2.

If you're using that table, it will try to set the protocol to unknown,
with is wrong, and have an unpredictable result, as, on some boards,
the em28xx will be working with NEC protocol, while, on others, with
RC5.

You should, instead, use this table:

$ more keytable/rc_keymaps/hauppauge
# table hauppauge, type: RC5
0x1e3b KEY_SELECT
0x1e3d KEY_POWER2
0x1e1c KEY_TV
0x1e18 KEY_VIDEO
0x1e19 KEY_AUDIO
0x1e1a KEY_CAMERA
0x1e1b KEY_EPG
0x1e0c KEY_RADIO
0x1e14 KEY_UP
0x1e15 KEY_DOWN
0x1e16 KEY_LEFT
0x1e17 KEY_RIGHT
0x1e25 KEY_OK
...

There, the protocol there seems to be properly identified as RC5, and
the ir-keytable will use RC5 type when setting it.

Regards,
Mauro

  parent reply	other threads:[~2013-06-13 10:50 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-18 13:57 3.9.2 kernel - IR / em28xx_rc broken? Chris Rankin
2013-05-18 14:36 ` Frank Schäfer
2013-05-18 15:17   ` Chris Rankin
2013-05-18 16:58     ` Frank Schäfer
2013-05-18 21:02       ` Chris Rankin
2013-05-19 13:40         ` Frank Schäfer
2013-05-19 14:11           ` Chris Rankin
2013-05-19 17:26             ` Frank Schäfer
2013-05-19 19:59               ` Chris Rankin
2013-05-19 21:02                 ` Frank Schäfer
2013-05-19 22:36                   ` Chris Rankin
2013-05-19 23:04                   ` Chris Rankin
2013-05-20 12:38                     ` Frank Schäfer
2013-05-20 12:47                       ` Frank Schäfer
2013-05-20 13:01                       ` Chris Rankin
2013-05-20 13:43                         ` Frank Schäfer
2013-05-20 14:51                           ` Chris Rankin
2013-05-20 15:36                             ` Frank Schäfer
2013-05-20 16:02                               ` Chris Rankin
2013-06-13 10:39                               ` Mauro Carvalho Chehab
2013-06-13 10:50                         ` Mauro Carvalho Chehab [this message]
2013-05-20  0:45                   ` Chris Rankin
2013-05-20 12:40                     ` Frank Schäfer
2013-05-20 12:48                       ` Chris Rankin
2013-05-18 21:11       ` Chris Rankin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130613075037.0da24c13@redhat.com \
    --to=mchehab@redhat.com \
    --cc=fschaefer.oss@googlemail.com \
    --cc=linux-media@vger.kernel.org \
    --cc=rankincj@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.