From: Ralf Baechle <ralf@linux-mips.org>
To: Matt Porter <mporter@kernel.crashing.org>,
Alexandre Bounine <alexandre.bounine@idt.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH] RAPIDIO: Fix idt_gen2.c build
Date: Thu, 13 Jun 2013 17:42:31 +0200 [thread overview]
Message-ID: <20130613154231.GA27745@linux-mips.org> (raw)
idt_gen2.c relies that one of the header files used will include
<asm/page.h> which will define the required symbol PAGE_SIZE. On MIPS
for example <asm/page.h> will not be included implicitly which will
result in the following build error:
CC drivers/rapidio/switches/idt_gen2.o
drivers/rapidio/switches/idt_gen2.c: In function ‘idtg2_show_errlog’:
drivers/rapidio/switches/idt_gen2.c:379:30: error: ‘PAGE_SIZE’ undeclared (first use in this function)
drivers/rapidio/switches/idt_gen2.c:379:30: note: each undeclared identifier is reported only once for each function it appears in
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
---
If you're ok with this patch I can put it into my next pull request for
Linux. Thanks!
drivers/rapidio/switches/idt_gen2.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/rapidio/switches/idt_gen2.c b/drivers/rapidio/switches/idt_gen2.c
index 809b7a3..5d3b0f0 100644
--- a/drivers/rapidio/switches/idt_gen2.c
+++ b/drivers/rapidio/switches/idt_gen2.c
@@ -15,6 +15,8 @@
#include <linux/rio_drv.h>
#include <linux/rio_ids.h>
#include <linux/delay.h>
+
+#include <asm/page.h>
#include "../rio.h"
#define LOCAL_RTE_CONF_DESTID_SEL 0x010070
next reply other threads:[~2013-06-13 15:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-13 15:42 Ralf Baechle [this message]
2013-06-13 15:51 ` [PATCH] RAPIDIO: Fix idt_gen2.c build Bounine, Alexandre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130613154231.GA27745@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=alexandre.bounine@idt.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mporter@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.