From: Anton Vorontsov <anton@enomsg.org>
To: Oded Gabbay <ogabbay@advaoptical.com>
Cc: cjb@laptop.org, shawn.guo@linaro.org,
Chang-Ming.Huang@freescale.com, wfp5p@virginia.edu,
gregkh@linuxfoundation.org, linux-mmc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] MMC: P2020 SDHC: Add support for 8-bit bus width and non-removable card
Date: Thu, 13 Jun 2013 11:17:59 -0700 [thread overview]
Message-ID: <20130613181759.GA27040@teo> (raw)
In-Reply-To: <1371045205-3164-1-git-send-email-ogabbay@advaoptical.com>
On Wed, Jun 12, 2013 at 04:53:25PM +0300, Oded Gabbay wrote:
> @@ -262,7 +288,23 @@ static const struct sdhci_pltfm_data sdhci_esdhc_pdata = {
>
> static int sdhci_esdhc_probe(struct platform_device *pdev)
> {
> - return sdhci_pltfm_register(pdev, &sdhci_esdhc_pdata);
> + struct sdhci_host *host;
> + int ret = 0;
No need for the 0 initializer.
Otherwise it looks OK, thanks!
Reviewed-by: Anton Vorontsov <anton@enomsg.org>
prev parent reply other threads:[~2013-06-13 18:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-12 13:53 [PATCH 1/2] MMC: P2020 SDHC: Add support for 8-bit bus width and non-removable card Oded Gabbay
2013-06-12 13:53 ` Oded Gabbay
2013-06-13 18:17 ` Anton Vorontsov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130613181759.GA27040@teo \
--to=anton@enomsg.org \
--cc=Chang-Ming.Huang@freescale.com \
--cc=cjb@laptop.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ogabbay@advaoptical.com \
--cc=shawn.guo@linaro.org \
--cc=wfp5p@virginia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.