From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Horman Date: Fri, 14 Jun 2013 01:02:54 +0000 Subject: Re: [PATCH 14/15] ARM: shmobile: Remove AP4EVB board support Message-Id: <20130614010254.GD7284@verge.net.au> List-Id: References: <1371106793-25071-1-git-send-email-horms+renesas@verge.net.au> <1371106793-25071-15-git-send-email-horms+renesas@verge.net.au> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org On Thu, Jun 13, 2013 at 09:36:51PM +0200, Guennadi Liakhovetski wrote: > Hi Simon > > On Thu, 13 Jun 2013, Simon Horman wrote: > > > From: Magnus Damm > > > > Remove board support for the sh7372 based AP4EVB board > > > > The sh7372 SoC support code is still kept around since it > > is in use by the Mackerel board which is basically a more > > recent board where the design is based on AP4EVB. > > > > Signed-off-by: Magnus Damm > > Signed-off-by: Simon Horman > > It would be a pity if this patch gets pulled now. We're still discussing > with Magnus, I believe. My opinion is, that this board is a good testing > platform for V4L2. It is the only board in the mainline, using the CSI2 > interface, present on multiple Renesas SoCs, including r8a73a4 (APE6), and > (probably, not 100% sure) sh73a0 (AG5), and the IMX074 camera sensor, not > present on any other platform. If this board is removed, supporting both > CSI2 and IMX074 will become difficult. Besides, AP4EVB is used as an > example in my V4L2 clock / async probing patch series: > > http://www.mail-archive.com/linux-media@vger.kernel.org/msg63174.html > > If still possible, would be good to delay removing this board until we > complete our discussion. Does the board still work with the rest of this series applied? > > Thanks > Guennadi > > > --- > > arch/arm/configs/ap4evb_defconfig | 56 - > > arch/arm/mach-shmobile/Kconfig | 21 - > > arch/arm/mach-shmobile/Makefile | 1 - > > arch/arm/mach-shmobile/Makefile.boot | 1 - > > arch/arm/mach-shmobile/board-ap4evb.c | 1310 -------------------- > > .../arm/mach-shmobile/include/mach/head-ap4evb.txt | 93 -- > > arch/arm/mach-shmobile/include/mach/mmc-ap4eb.h | 29 - > > arch/arm/mach-shmobile/include/mach/mmc.h | 4 +- > > arch/arm/mach-shmobile/include/mach/zboot.h | 6 +- > > 9 files changed, 2 insertions(+), 1519 deletions(-) > > delete mode 100644 arch/arm/configs/ap4evb_defconfig > > delete mode 100644 arch/arm/mach-shmobile/board-ap4evb.c > > delete mode 100644 arch/arm/mach-shmobile/include/mach/head-ap4evb.txt > > delete mode 100644 arch/arm/mach-shmobile/include/mach/mmc-ap4eb.h > > > > diff --git a/arch/arm/configs/ap4evb_defconfig b/arch/arm/configs/ap4evb_defconfig > > deleted file mode 100644 > > index 66894f7..0000000 > > --- a/arch/arm/configs/ap4evb_defconfig > > +++ /dev/null > > @@ -1,56 +0,0 @@ > > -CONFIG_EXPERIMENTAL=y > > -CONFIG_SYSVIPC=y > > -CONFIG_IKCONFIG=y > > -CONFIG_IKCONFIG_PROC=y > > -CONFIG_LOG_BUF_SHIFT > > -CONFIG_BLK_DEV_INITRD=y > > -CONFIG_SLAB=y > > -# CONFIG_BLK_DEV_BSG is not set > > -# CONFIG_IOSCHED_DEADLINE is not set > > -# CONFIG_IOSCHED_CFQ is not set > > -CONFIG_ARCH_SHMOBILE=y > > -CONFIG_ARCH_SH7372=y > > -CONFIG_MACH_AP4EVB=y > > -CONFIG_AEABI=y > > -# CONFIG_OABI_COMPAT is not set > > -CONFIG_ZBOOT_ROM_TEXT=0x0 > > -CONFIG_ZBOOT_ROM_BSS=0x0 > > -CONFIG_CMDLINE="console=ttySC0,115200 earlyprintk=sh-sci.0,115200" > > -CONFIG_KEXEC=y > > -CONFIG_PM=y > > -# CONFIG_SUSPEND is not set > > -CONFIG_UEVENT_HELPER_PATH="/sbin/hotplug" > > -# CONFIG_FIRMWARE_IN_KERNEL is not set > > -CONFIG_MTD=y > > -CONFIG_MTD_CONCAT=y > > -CONFIG_MTD_PARTITIONS=y > > -CONFIG_MTD_CHAR=y > > -CONFIG_MTD_BLOCK=y > > -CONFIG_MTD_CFI=y > > -CONFIG_MTD_CFI_INTELEXT=y > > -CONFIG_MTD_PHYSMAP=y > > -CONFIG_MTD_NAND=y > > -# CONFIG_BLK_DEV is not set > > -# CONFIG_MISC_DEVICES is not set > > -# CONFIG_INPUT_MOUSEDEV_PSAUX is not set > > -# CONFIG_INPUT_KEYBOARD is not set > > -# CONFIG_INPUT_MOUSE is not set > > -# CONFIG_SERIO is not set > > -CONFIG_SERIAL_SH_SCI=y > > -CONFIG_SERIAL_SH_SCI_NR_UARTS=8 > > -CONFIG_SERIAL_SH_SCI_CONSOLE=y > > -# CONFIG_LEGACY_PTYS is not set > > -# CONFIG_HW_RANDOM is not set > > -# CONFIG_HWMON is not set > > -# CONFIG_VGA_CONSOLE is not set > > -# CONFIG_HID_SUPPORT is not set > > -# CONFIG_USB_SUPPORT is not set > > -# CONFIG_DNOTIFY is not set > > -CONFIG_TMPFS=y > > -# CONFIG_MISC_FILESYSTEMS is not set > > -CONFIG_MAGIC_SYSRQ=y > > -CONFIG_DEBUG_KERNEL=y > > -# CONFIG_DETECT_SOFTLOCKUP is not set > > -# CONFIG_RCU_CPU_STALL_DETECTOR is not set > > -# CONFIG_FTRACE is not set > > -# CONFIG_CRC32 is not set > > diff --git a/arch/arm/mach-shmobile/Kconfig b/arch/arm/mach-shmobile/Kconfig > > index 747f68a..ae1a530 100644 > > --- a/arch/arm/mach-shmobile/Kconfig > > +++ b/arch/arm/mach-shmobile/Kconfig > > @@ -69,27 +69,6 @@ config ARCH_EMEV2 > > > > comment "SH-Mobile Board Type" > > > > -config MACH_AP4EVB > > - bool "AP4EVB board" > > - depends on ARCH_SH7372 > > - select ARCH_REQUIRE_GPIOLIB > > - select REGULATOR_FIXED_VOLTAGE if REGULATOR > > - select SH_LCD_MIPI_DSI > > - select SND_SOC_AK4642 if SND_SIMPLE_CARD > > - > > -choice > > - prompt "AP4EVB LCD panel selection" > > - default AP4EVB_QHD > > - depends on MACH_AP4EVB > > - > > -config AP4EVB_QHD > > - bool "MIPI-DSI QHD (960x540)" > > - > > -config AP4EVB_WVGA > > - bool "Parallel WVGA (800x480)" > > - > > -endchoice > > - > > config MACH_AG5EVM > > bool "AG5EVM board" > > depends on ARCH_SH73A0 > > diff --git a/arch/arm/mach-shmobile/Makefile b/arch/arm/mach-shmobile/Makefile > > index 068f1da..aae28f3 100644 > > --- a/arch/arm/mach-shmobile/Makefile > > +++ b/arch/arm/mach-shmobile/Makefile > > @@ -35,7 +35,6 @@ obj-$(CONFIG_ARCH_R8A7779) += pm-r8a7779.o > > obj-$(CONFIG_ARCH_SH73A0) += pm-sh73a0.o > > > > # Board objects > > -obj-$(CONFIG_MACH_AP4EVB) += board-ap4evb.o > > obj-$(CONFIG_MACH_AG5EVM) += board-ag5evm.o > > obj-$(CONFIG_MACH_APE6EVM) += board-ape6evm.o > > obj-$(CONFIG_MACH_MACKEREL) += board-mackerel.o > > diff --git a/arch/arm/mach-shmobile/Makefile.boot b/arch/arm/mach-shmobile/Makefile.boot > > index 6b147ea..3030673 100644 > > --- a/arch/arm/mach-shmobile/Makefile.boot > > +++ b/arch/arm/mach-shmobile/Makefile.boot > > @@ -1,7 +1,6 @@ > > # per-board load address for uImage > > loadaddr-y :> > loadaddr-$(CONFIG_MACH_AG5EVM) += 0x40008000 > > -loadaddr-$(CONFIG_MACH_AP4EVB) += 0x40008000 > > loadaddr-$(CONFIG_MACH_APE6EVM) += 0x40008000 > > loadaddr-$(CONFIG_MACH_ARMADILLO800EVA) += 0x40008000 > > loadaddr-$(CONFIG_MACH_ARMADILLO800EVA_REFERENCE) += 0x40008000 > > diff --git a/arch/arm/mach-shmobile/board-ap4evb.c b/arch/arm/mach-shmobile/board-ap4evb.c > > deleted file mode 100644 > > index 297bf5e..0000000 > > --- a/arch/arm/mach-shmobile/board-ap4evb.c > > +++ /dev/null > > @@ -1,1310 +0,0 @@ > > -/* > > - * AP4EVB board support > > - * > > - * Copyright (C) 2010 Magnus Damm > > - * Copyright (C) 2008 Yoshihiro Shimoda > > - * > > - * This program is free software; you can redistribute it and/or modify > > - * it under the terms of the GNU General Public License as published by > > - * the Free Software Foundation; version 2 of the License. > > - * > > - * This program is distributed in the hope that it will be useful, > > - * but WITHOUT ANY WARRANTY; without even the implied warranty of > > - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > > - * GNU General Public License for more details. > > - * > > - * You should have received a copy of the GNU General Public License > > - * along with this program; if not, write to the Free Software > > - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA > > - */ > > -#include > > -#include > > -#include > > -#include > > -#include > > -#include > > -#include > > -#include > > -#include > > -#include > > -#include > > -#include > > -#include > > -#include > > -#include > > -#include > > -#include > > -#include > > -#include > > -#include > > -#include > > -#include > > -#include > > -#include > > -#include > > -#include > > -#include > > -#include > > -#include > > -#include > > - > > -#include > > -#include > > -#include > > - > > -#include > > -#include > > - > > -#include