Re: [PATCH 4/4] perf tools: Retry mapping buffers readonly on EACCES

[Robert Richter <rric@kernel.org>]

On 14.06.13 11:08:40, Namhyung Kim wrote:
> > -	if (perf_evlist__mmap(evlist, opts->mmap_pages, false) < 0) {
> > +try_again2:
> > +	if (perf_evlist__mmap(evlist, opts->mmap_pages, opts->mmap_ro) < 0) {
> > +		if (!opts->mmap_ro && errno == EACCES) {
> > +			opts->mmap_ro = true;
> > +			goto try_again2;
> > +		}
> >  		ui__error("Failed to mmap with %d (%s)\n",
> >  			    errno, strerror(errno));
> >  		goto out_err;
> 
> 
> You will need this also:
> 
> 
> @@ -161,7 +161,8 @@ static int perf_record__mmap_read(struct perf_record *rec,
>         }
>  
>         md->prev = old;
> -       perf_mmap__write_tail(md, old);
> +       if (!rec->opts.mmap_ro)
> +               perf_mmap__write_tail(md, old);
>  
>  out:
>         return rc;

Yes, indeed. Will add your change

-Robert