From: Mark Brown <broonie@kernel.org>
To: Nicolin Chen <b42378@freescale.com>
Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH] ASoC: WM8962: Enable start-up and normal bias after reset in runtime resume
Date: Fri, 14 Jun 2013 10:59:17 +0100 [thread overview]
Message-ID: <20130614095917.GG1403@sirena.org.uk> (raw)
In-Reply-To: <1371199940-29803-1-git-send-email-b42378@freescale.com>
[-- Attachment #1.1: Type: text/plain, Size: 939 bytes --]
On Fri, Jun 14, 2013 at 04:52:20PM +0800, Nicolin Chen wrote:
> The analogue circuits in WM8962 require a mid-rail analogue reference
> voltage, VMID, which generator is enabled by STARTUP_BIAS_ENA bit,
> while VMID_BUF_ENA bit can enable buffered VMID to avoid audible pops.
>
> Besides, these circuits also need a bias current enabled by BIAS_ENA.
>
> Then set VMID_SEL to 2x5k divider, the fast start-up mode, to power it
> up. And let set_bias_level() handle its 2x250k for low power standby
> and 2x50k for normal operation.
>
> This patch might be kinda reverting operation against commit 52c0eee3
> but after testing with WM8962 CODEC, these configurations during power
> up should be essential and soc-core would not do any of them. So the
> codec drvier need to handle it.
The biases should be being managed using set_bias_level() which will get
called automatically when audio is being started and stopped.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2013-06-14 9:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-14 8:52 [PATCH] ASoC: WM8962: Enable start-up and normal bias after reset in runtime resume Nicolin Chen
2013-06-14 9:59 ` Mark Brown [this message]
2013-06-14 10:08 ` Nicolin Chen
2013-06-14 10:51 ` Mark Brown
2013-06-14 11:07 ` Nicolin Chen
2013-06-14 11:21 ` Mark Brown
2013-06-14 11:36 ` Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130614095917.GG1403@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=b42378@freescale.com \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.