From: John Keeping <john@keeping.me.uk>
To: Ramkumar Ramachandra <artagnon@gmail.com>
Cc: Git List <git@vger.kernel.org>, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] format-patch: remove existing output-directory
Date: Fri, 14 Jun 2013 14:10:26 +0100 [thread overview]
Message-ID: <20130614130910.GF23890@serenity.lan> (raw)
In-Reply-To: <1371213813-7925-1-git-send-email-artagnon@gmail.com>
On Fri, Jun 14, 2013 at 06:13:33PM +0530, Ramkumar Ramachandra wrote:
> The following command
>
> $ git format-patch -o outgoing master
>
> does not ensure that the output-directory outgoing doesn't already
> exist. As a result, it's possible for patches from two different series
> to get mixed up if the user is not careful. Fix the problem by
> unconditionally removing the output-directory before writing to it.
I don't think this is the correct behaviour. I can think of cases where
I would want to output multiple things into the same directory.
It may be better to issue a warning when this happens, or die and
provide a flag to let the user bypass that.
next prev parent reply other threads:[~2013-06-14 13:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-14 12:43 [PATCH] format-patch: remove existing output-directory Ramkumar Ramachandra
2013-06-14 13:10 ` John Keeping [this message]
2013-06-14 13:15 ` Ramkumar Ramachandra
2013-06-14 13:21 ` John Keeping
2013-06-14 13:58 ` Junio C Hamano
2013-06-14 13:55 ` Junio C Hamano
2013-06-14 13:16 ` Fredrik Gustafsson
2013-06-14 13:34 ` Ramkumar Ramachandra
2013-06-14 13:48 ` Fredrik Gustafsson
2013-06-14 13:52 ` Ramkumar Ramachandra
2013-06-14 13:50 ` SZEDER Gábor
2013-06-14 13:51 ` Ramkumar Ramachandra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130614130910.GF23890@serenity.lan \
--to=john@keeping.me.uk \
--cc=artagnon@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.