All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oleg Nesterov <oleg@redhat.com>
To: James Hogan <james.hogan@imgtec.com>
Cc: linux-kernel@vger.kernel.org, Ralf Baechle <ralf@linux-mips.org>,
	David Daney <david.daney@cavium.com>,
	Al Viro <viro@zeniv.linux.org.uk>,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
	David Howells <dhowells@redhat.com>,
	Dave Jones <davej@redhat.com>,
	linux-mips@linux-mips.org
Subject: Re: [PATCH v2] MIPS: Reduce _NSIG from 128 to 127 to avoid BUG_ON
Date: Fri, 14 Jun 2013 18:22:44 +0200	[thread overview]
Message-ID: <20130614162244.GA15754@redhat.com> (raw)
In-Reply-To: <1371225825-8225-1-git-send-email-james.hogan@imgtec.com>

On 06/14, James Hogan wrote:
>
> However do_group_exit() checks for the core dump bit (0x80) in the exit
> code which matches in this particular case and the kernel panics:
>
>   BUG_ON(exit_code & 0x80); /* core dumps don't get here */
>
> Lets avoid this by changing the ABI by reducing the number of signals to
> 127 (so that the maximum signal number is 127).

Agreed.

Of course I can't ack the change in arch/mips, but to me this looks
like a best solution.

Oleg.

  reply	other threads:[~2013-06-14 16:27 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-14 16:03 [PATCH v2] MIPS: Reduce _NSIG from 128 to 127 to avoid BUG_ON James Hogan
2013-06-14 16:03 ` James Hogan
2013-06-14 16:22 ` Oleg Nesterov [this message]
2013-06-14 16:28 ` David Daney
2013-06-14 16:28   ` David Daney
2013-06-17 10:36 ` James Hogan
2013-06-17 10:36   ` James Hogan
2013-06-28 19:28   ` Denys Vlasenko
2013-06-28 22:03     ` James Hogan
2013-09-04  4:41       ` Rich Felker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130614162244.GA15754@redhat.com \
    --to=oleg@redhat.com \
    --cc=davej@redhat.com \
    --cc=david.daney@cavium.com \
    --cc=dhowells@redhat.com \
    --cc=james.hogan@imgtec.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=ralf@linux-mips.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.