All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anton Vorontsov <anton@enomsg.org>
To: Rob Herring <robherring2@gmail.com>
Cc: Tony Luck <tony.luck@gmail.com>,
	Kees Cook <keescook@chromium.org>,
	Colin Cross <ccross@android.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] pstore/ram for 3.11
Date: Fri, 14 Jun 2013 15:47:09 -0700	[thread overview]
Message-ID: <20130614224708.GA15085@teo> (raw)
In-Reply-To: <51BB99F0.6030607@gmail.com>

On Fri, Jun 14, 2013 at 05:32:16PM -0500, Rob Herring wrote:
> https://lkml.org/lkml/2013/4/9/831
> 
> The main discussion was around the write-combining change which I
> dropped. You can pick patches 2 and 3 off the mail list if you prefer. I
> would assume they only require an ack from one of the 4 of you which
> pulling the tree implicitly does.

I've just re-reviewed the discussion. I see Colin was talking about ftrace
causing infinite loops due to recursion. Once I stumbled onto this too
(but the issue itself was due to missing 'notrace' mark), and Stephen told
that recursion protection is kind of mandatory:

  http://lists.linaro.org/pipermail/linaro-kernel/2012-August/002084.html

I belive that the protection is actually there nowadays, and that is why
Rob does not see the problem with his patch.

So, I guess the patches are good, at least they fix real issues for Rob.
:)

	Acked-by: Anton Vorontsov <anton@enomsg.org>

(Or I can pick this via linux-pstore.git tree, I'll let Tony decide.)

Thanks!

Anton

  reply	other threads:[~2013-06-14 22:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-13  3:44 [GIT PULL] pstore/ram for 3.11 Rob Herring
2013-06-14 22:18 ` Tony Luck
2013-06-14 22:32   ` Rob Herring
2013-06-14 22:47     ` Anton Vorontsov [this message]
2013-06-14 22:57       ` Tony Luck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130614224708.GA15085@teo \
    --to=anton@enomsg.org \
    --cc=ccross@android.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robherring2@gmail.com \
    --cc=tony.luck@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.