From: Wanpeng Li <liwanp@linux.vnet.ibm.com>
To: Tejun Heo <tj@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@suse.cz>,
David Rientjes <rientjes@google.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Fengguang Wu <fengguang.wu@intel.com>,
Rik van Riel <riel@redhat.com>,
Andrew Shewmaker <agshew@gmail.com>,
Jiri Kosina <jkosina@suse.cz>, Namjae Jeon <linkinjeon@gmail.com>,
Jan Kara <jack@suse.cz>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/8] mm/writeback: rename WB_REASON_FORKER_THREAD to WB_REASON_WORKER_THREAD
Date: Sun, 16 Jun 2013 08:10:37 +0800 [thread overview]
Message-ID: <20130616001037.GA17121@hacker.(null)> (raw)
In-Reply-To: <20130614175710.GB6593@mtj.dyndns.org>
On Fri, Jun 14, 2013 at 10:57:10AM -0700, Tejun Heo wrote:
>On Fri, Jun 14, 2013 at 03:30:37PM +0800, Wanpeng Li wrote:
>> After commit 839a8e86("writeback: replace custom worker pool implementation
>> with unbound workqueue"), there is no bdi forker thread any more. This patch
>> rename WB_REASON_FORKER_THREAD to WB_REASON_WORKER_THREAD since works are
>> done by emergency worker.
>
>This is somewhat userland visible and we'll be exposing exactly the
>same information with just a different name. While the string doesn't
>match the current implementation exactly, I don't think we need to
>change it. Maybe add a comment there saying why it has a mismatching
>name is enough?
>
Good point, I will update them in next version, thanks for your review.
;-)
Regards,
Wanpeng Li
>Thanks.
>
>--
>tejun
>
>--
>To unsubscribe, send a message with 'unsubscribe linux-mm' in
>the body to majordomo@kvack.org. For more info on Linux MM,
>see: http://www.linux-mm.org/ .
>Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-06-16 0:10 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-14 7:30 [PATCH 1/8] mm/writeback: fix wb_do_writeback exported unsafely Wanpeng Li
2013-06-14 7:30 ` Wanpeng Li
2013-06-14 7:30 ` [PATCH 2/8] mm/writeback: remove wb_reason_name Wanpeng Li
2013-06-14 7:30 ` Wanpeng Li
2013-06-14 7:30 ` [PATCH 3/8] mm/writeback: Don't check force_wait to handle bdi->work_list Wanpeng Li
2013-06-14 7:30 ` Wanpeng Li
2013-06-14 7:30 ` [PATCH 4/8] mm/writeback: rename WB_REASON_FORKER_THREAD to WB_REASON_WORKER_THREAD Wanpeng Li
2013-06-14 7:30 ` Wanpeng Li
2013-06-14 17:57 ` Tejun Heo
2013-06-14 17:57 ` Tejun Heo
2013-06-16 0:10 ` Wanpeng Li [this message]
2013-06-16 0:10 ` Wanpeng Li
2013-06-14 7:30 ` [PATCH 5/8] mm/page_alloc: fix blank in show_free_areas Wanpeng Li
2013-06-14 7:30 ` Wanpeng Li
2013-06-14 7:30 ` [PATCH 6/8] mm/page_alloc: fix doc for numa_zonelist_order Wanpeng Li
2013-06-14 7:30 ` Wanpeng Li
2013-06-14 7:30 ` [PATCH 7/8] mm/thp: fix doc for transparent huge zero page Wanpeng Li
2013-06-14 7:30 ` Wanpeng Li
2013-06-14 8:28 ` Kirill A. Shutemov
2013-06-14 8:28 ` Kirill A. Shutemov
2013-06-14 7:30 ` [PATCH 8/8] mm/pgtable: Don't accumulate addr during pgd prepopulate pmd Wanpeng Li
2013-06-14 7:30 ` Wanpeng Li
2013-06-14 9:02 ` [PATCH 1/8] mm/writeback: fix wb_do_writeback exported unsafely Michal Hocko
2013-06-14 9:02 ` Michal Hocko
2013-06-14 9:14 ` Wanpeng Li
2013-06-14 9:14 ` Wanpeng Li
2013-06-14 9:29 ` Kirill A. Shutemov
2013-06-14 9:29 ` Kirill A. Shutemov
2013-06-14 9:31 ` Michal Hocko
2013-06-14 9:31 ` Michal Hocko
2013-06-14 9:38 ` Zhang Yanfei
2013-06-14 9:38 ` Zhang Yanfei
2013-06-14 9:31 ` Haicheng Li
2013-06-14 9:31 ` Haicheng Li
2013-06-14 9:41 ` Wanpeng Li
2013-06-14 9:41 ` Wanpeng Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='20130616001037.GA17121@hacker.(null)' \
--to=liwanp@linux.vnet.ibm.com \
--cc=agshew@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=jack@suse.cz \
--cc=jkosina@suse.cz \
--cc=kirill.shutemov@linux.intel.com \
--cc=linkinjeon@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.