From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Horman Subject: Re: [PATCH net-next 3/5] mv643xx_eth.c: convert skb->end into skb_end_poitner(skb) Date: Mon, 17 Jun 2013 11:02:18 +0900 Message-ID: <20130617020218.GD15043@verge.net.au> References: <7629c2a65cffd7b61d100703567e027a2850c3c6.1371200138.git.yamahata@valinux.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, Lennert Buytenhek To: Isaku Yamahata Return-path: Received: from kirsty.vergenet.net ([202.4.237.240]:42464 "EHLO kirsty.vergenet.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754261Ab3FQCBP (ORCPT ); Sun, 16 Jun 2013 22:01:15 -0400 Content-Disposition: inline In-Reply-To: <7629c2a65cffd7b61d100703567e027a2850c3c6.1371200138.git.yamahata@valinux.co.jp> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, Jun 14, 2013 at 05:58:33PM +0900, Isaku Yamahata wrote: > The change set of 4305b541 "[SK_BUFF]: Convert skb->end to sk_buff_data_t" > converted skb->end from pointer to sk_buff_data_t. > The pointed value should be accessed via skb_end_pointer(). > > Since arm or ppc arch doesn't define NET_SKBUFF_DATA_USES_OFFSET, > skb->end is effectively pointer. So it doesn't cause a real problem. > But this patch is good for consistency. > > Found by inspection. Compile test only. > > Cc: Simon Horman > Cc: Lennert Buytenhek > Signed-off-by: Isaku Yamahata Reviewed-by: Simon Horman > --- > drivers/net/ethernet/marvell/mv643xx_eth.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/marvell/mv643xx_eth.c b/drivers/net/ethernet/marvell/mv643xx_eth.c > index c7f9fb3..510d506 100644 > --- a/drivers/net/ethernet/marvell/mv643xx_eth.c > +++ b/drivers/net/ethernet/marvell/mv643xx_eth.c > @@ -621,7 +621,7 @@ static int rxq_refill(struct rx_queue *rxq, int budget) > > rx_desc = rxq->rx_desc_area + rx; > > - size = skb->end - skb->data; > + size = skb_end_pointer(skb) - skb->data; > rx_desc->buf_ptr = dma_map_single(mp->dev->dev.parent, > skb->data, size, > DMA_FROM_DEVICE); > -- > 1.7.10.4 > > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >