All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge.net.au>
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: netdev@vger.kernel.org, Li RongQing <roy.qing.li@gmail.com>,
	linux-scsi@vger.kernel.org
Subject: Re: [PATCH net-next 2/5] net, scsi/csgb4i: convert skb->transport_header into skb_transport_header(skb)
Date: Mon, 17 Jun 2013 11:04:11 +0900	[thread overview]
Message-ID: <20130617020411.GF15043@verge.net.au> (raw)
In-Reply-To: <7ae8c4225b5d19a2ad7d621bc7e08a74b1b4583e.1371200138.git.yamahata@valinux.co.jp>

On Fri, Jun 14, 2013 at 05:58:32PM +0900, Isaku Yamahata wrote:
> The change set of 1a37e412, "net: Use 16bits for *_headers fields
> of struct skbuff" converted from sk_buff_data_t into 16bit integer.
> So skb->tail needs to be converted to skb_tail_pointer(skb).
> 
> Found by inspection. Compile tested only.
> 
> Cc: Simon Horman <horms@verge.net.au>
> Cc: Li RongQing <roy.qing.li@gmail.com>
> Cc: linux-scsi@vger.kernel.org
> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>

Acked-by: Simon Horman <horms@verge.net.au>

> ---
>  drivers/scsi/cxgbi/cxgb4i/cxgb4i.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c b/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c
> index 3fecf35..9138d4e 100644
> --- a/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c
> +++ b/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c
> @@ -358,7 +358,7 @@ static inline unsigned int calc_tx_flits_ofld(const struct sk_buff *skb)
>  		return DIV_ROUND_UP(skb->len, 8);
>  	flits = skb_transport_offset(skb) / 8;
>  	cnt = skb_shinfo(skb)->nr_frags;
> -	if (skb->tail != skb->transport_header)
> +	if (skb_tail_pointer(skb) != skb_transport_header(skb))
>  		cnt++;
>  	return flits + sgl_len(cnt);
>  }
> -- 
> 1.7.10.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

  reply	other threads:[~2013-06-17  2:03 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-14  8:58 [PATCH net-next 1/5] net, atm/ambassader: convert skb->tail into skb_tail_pointer(skb) Isaku Yamahata
2013-06-14  8:58 ` [PATCH net-next 2/5] net, scsi/csgb4i: convert skb->transport_header into skb_transport_header(skb) Isaku Yamahata
2013-06-17  2:04   ` Simon Horman [this message]
2013-06-18  0:13     ` David Miller
2013-06-14  8:58 ` [PATCH net-next 3/5] mv643xx_eth.c: convert skb->end into skb_end_poitner(skb) Isaku Yamahata
2013-06-17  2:02   ` Simon Horman
2013-06-18  0:13     ` David Miller
2013-06-14  8:58 ` [PATCH net-next 4/5] pxa168_eth: convert skb->end into skb_end_pointer(skb) Isaku Yamahata
2013-06-17  2:01   ` Simon Horman
2013-06-18  0:13     ` David Miller
2013-06-14  8:58 ` [PATCH net-next 5/5] staging/rtl8192u: convert skb->tail into skb_tail_pointer(skb) Isaku Yamahata
2013-06-17  2:03   ` Simon Horman
2013-06-18  0:13     ` David Miller
2013-06-17 22:45   ` Greg Kroah-Hartman
2013-06-17  2:01 ` [PATCH net-next 1/5] net, atm/ambassader: " Simon Horman
2013-06-18  0:13   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130617020411.GF15043@verge.net.au \
    --to=horms@verge.net.au \
    --cc=linux-scsi@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=roy.qing.li@gmail.com \
    --cc=yamahata@valinux.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.