Re: [PATCH v2 3/7] mm/writeback: commit reason of WB_REASON_FORKER_THREAD mismatch name

[Wanpeng Li <liwanp@linux.vnet.ibm.com>]

On Mon, Jun 17, 2013 at 10:30:30AM +0200, Michal Hocko wrote:
>On Sun 16-06-13 09:14:46, Wanpeng Li wrote:
>> After commit 839a8e86("writeback: replace custom worker pool implementation
>> with unbound workqueue"), there is no bdi forker thread any more. However,
>> WB_REASON_FORKER_THREAD is still used due to it is somewhat userland visible 
>
>What exactly "somewhat userland visible" means?
>Is this about trace events?

Thanks for the question, Tejun, could you explain this for us? ;-)

Regards,
Wanpeng Li 

>
>> and we won't be exposing exactly the same information with just a different 
>> name. 
>> 
>> Signed-off-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>
>> ---
>>  include/linux/writeback.h | 5 +++++
>>  1 file changed, 5 insertions(+)
>> 
>> diff --git a/include/linux/writeback.h b/include/linux/writeback.h
>> index 8b5cec4..cf077a7 100644
>> --- a/include/linux/writeback.h
>> +++ b/include/linux/writeback.h
>> @@ -47,6 +47,11 @@ enum wb_reason {
>>  	WB_REASON_LAPTOP_TIMER,
>>  	WB_REASON_FREE_MORE_MEM,
>>  	WB_REASON_FS_FREE_SPACE,
>> +/*
>> + * There is no bdi forker thread any more and works are done by emergency
>> + * worker, however, this is somewhat userland visible and we'll be exposing
>> + * exactly the same information, so it has a mismatch name.
>> + */
>>  	WB_REASON_FORKER_THREAD,
>>  
>>  	WB_REASON_MAX,
>> -- 
>> 1.8.1.2
>> 
>
>-- 
>Michal Hocko
>SUSE Labs

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>