From: Theodore Ts'o <tytso@mit.edu>
To: Jan Kara <jack@suse.cz>
Cc: Maarten ter Huurne <maarten@treewalker.org>,
Andreas Dilger <adilger.kernel@dilger.ca>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ext4: Fixed corruption when online resizing a fs with 1K block size
Date: Mon, 17 Jun 2013 09:07:03 -0400 [thread overview]
Message-ID: <20130617130703.GD24972@thunk.org> (raw)
In-Reply-To: <20130508135825.GA3810@quack.suse.cz>
On Wed, May 08, 2013 at 03:58:25PM +0200, Jan Kara wrote:
> On Mon 06-05-13 18:06:07, Maarten ter Huurne wrote:
> > Subtracting the number of the first data block places the superblock
> > backups one block too early, corrupting the file system. When the block
> > size is larger than 1K, the first data block is 0, so the subtraction
> > has no effect and no corruption occurs.
> Looking where mke2fs places backup super blocks you are right. You can
> add:
> Reviewed-by: Jan Kara <jack@suse.cz>
Applied, thanks.
- Ted
prev parent reply other threads:[~2013-06-17 13:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-06 16:06 [PATCH] ext4: Fixed corruption when online resizing a fs with 1K block size Maarten ter Huurne
2013-05-08 13:58 ` Jan Kara
2013-06-17 13:07 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130617130703.GD24972@thunk.org \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten@treewalker.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.