From: Thierry Reding <thierry.reding@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: Tushar Behera <tushar.behera@linaro.org>,
linux-kernel@vger.kernel.org, patches@linaro.org,
Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH 11/15] regulator: ti-abb: Convert to use devm_ioremap_resource
Date: Mon, 17 Jun 2013 21:45:14 +0200 [thread overview]
Message-ID: <20130617194512.GA5265@mithrandir> (raw)
In-Reply-To: <20130617160853.GG1403@sirena.org.uk>
[-- Attachment #1: Type: text/plain, Size: 1132 bytes --]
On Mon, Jun 17, 2013 at 05:08:53PM +0100, Mark Brown wrote:
> On Mon, Jun 17, 2013 at 04:04:52PM +0530, Tushar Behera wrote:
> > On 06/17/2013 03:35 PM, Mark Brown wrote:
> > > On Mon, Jun 17, 2013 at 02:42:25PM +0530, Tushar Behera wrote:
>
> > >> Ping.
> i
> > > Don't send contentless pings. I seem to recall you already got some
> > > review on this.
>
> >
> > The comment was on removal of the error message during
> > devm_ioremap_resource() error check . Since there are a few other error
> > messages in the driver (related to devm_ioremap_nocache) in the same
> > format, I prefer to leave this error message right now.
>
> So we should say the same thing repeatedly? That seems silly. That
> seems silly. It's like the contentless pings issue...
The intention was to make resource usage more consistent with the new
devm_ioremap_resource(). Part of the consistency involved to move all
error messages into the function so that callers shouldn't have to
worry about them anymore.
So I agree with Mark that there's really no use in keeping a second copy
of the error message.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-06-17 19:45 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-10 11:34 [PATCH 00/15] Convert to use devm_ioremap_resource Tushar Behera
2013-06-10 11:46 ` Tushar Behera
2013-06-10 11:34 ` [PATCH 01/15] sparc,leon: " Tushar Behera
2013-06-10 11:46 ` Tushar Behera
2013-06-10 12:03 ` Sachin Kamat
2013-06-10 12:15 ` Sachin Kamat
2013-06-11 3:07 ` Tushar Behera
2013-06-11 3:19 ` Tushar Behera
2013-06-17 9:07 ` [PATCH V2 1/15] " Tushar Behera
2013-06-17 9:19 ` Tushar Behera
2013-06-19 9:14 ` David Miller
2013-06-19 9:14 ` David Miller
2013-06-10 11:35 ` [PATCH 02/15] sudmac: " Tushar Behera
2013-06-17 6:11 ` Tushar Behera
2013-06-10 11:35 ` [PATCH 03/15] mmc: mvsdio: " Tushar Behera
2013-06-17 6:12 ` Tushar Behera
2013-06-10 11:35 ` [PATCH 04/15] gpio_msm: " Tushar Behera
2013-06-17 6:13 ` Tushar Behera
2013-06-10 11:35 ` [PATCH 05/15] gpio-sta2x11: " Tushar Behera
2013-06-17 6:13 ` Tushar Behera
2013-06-17 8:54 ` Linus Walleij
2013-06-10 11:35 ` [PATCH 06/15] net: bcm63xx_enet: " Tushar Behera
2013-06-12 9:23 ` David Miller
2013-06-10 11:35 ` [PATCH 07/15] net: fec: " Tushar Behera
2013-06-12 9:23 ` David Miller
2013-06-10 11:35 ` [PATCH 08/15] net: emaclite: " Tushar Behera
2013-06-12 9:23 ` David Miller
2013-06-10 11:35 ` [PATCH 09/15] net: can: " Tushar Behera
2013-06-10 13:09 ` Marc Kleine-Budde
2013-06-11 3:15 ` Tushar Behera
2013-06-12 3:09 ` 'Greg Kroah-Hartman'
2013-06-12 9:23 ` David Miller
2013-06-13 5:30 ` Tushar Behera
2013-06-13 5:41 ` Sachin Kamat
2013-06-10 11:35 ` [PATCH 10/15] Staging: netlogic: " Tushar Behera
2013-06-10 11:35 ` [PATCH 11/15] regulator: ti-abb: " Tushar Behera
2013-06-10 12:01 ` Sachin Kamat
2013-06-11 4:31 ` Tushar Behera
2013-06-17 9:12 ` Tushar Behera
2013-06-17 10:05 ` Mark Brown
2013-06-17 10:34 ` Tushar Behera
2013-06-17 16:08 ` Mark Brown
2013-06-17 19:45 ` Thierry Reding [this message]
2013-06-18 4:15 ` [PATCH V2 " Tushar Behera
2013-06-18 11:59 ` Mark Brown
2013-06-10 11:35 ` [PATCH 12/15] ASoC: spear: " Tushar Behera
2013-06-10 12:06 ` Sachin Kamat
2013-06-11 3:51 ` Tushar Behera
2013-06-17 9:13 ` [PATCH V2 " Tushar Behera
2013-06-17 10:20 ` Mark Brown
2013-06-17 10:40 ` [PATCH V3 " Tushar Behera
2013-06-17 16:20 ` Mark Brown
2013-06-17 16:20 ` Mark Brown
2013-06-10 11:35 ` [PATCH 13/15] pci: mvebu: " Tushar Behera
2013-06-10 14:29 ` Sachin Kamat
2013-06-11 4:51 ` Tushar Behera
2013-06-17 9:16 ` [PATCH V2 6/6] " Tushar Behera
2013-07-23 18:38 ` Bjorn Helgaas
2013-07-23 20:19 ` Ezequiel Garcia
2013-08-06 10:39 ` Thomas Petazzoni
2013-08-06 18:10 ` Bjorn Helgaas
2013-06-10 11:35 ` [PATCH 14/15] usb: phy: rcar-usb: Fix comment w.r.t. devm_ioremap_resource Tushar Behera
2013-06-10 12:17 ` Sergei Shtylyov
2013-06-11 3:21 ` Tushar Behera
2013-06-10 11:35 ` [PATCH 15/15] lib: devres: Remove deprecated devm_request_and_ioremap Tushar Behera
2013-06-12 12:43 ` Andy Shevchenko
2013-06-12 17:39 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130617194512.GA5265@mithrandir \
--to=thierry.reding@gmail.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@linaro.org \
--cc=tushar.behera@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.