Re: [Qemu-devel] [PULL 06/10] configure: dtc: Probe for libfdt_env.h

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1612 bytes --]

On Tue, Jun 18, 2013 at 12:44:02AM +0100, Peter Maydell wrote:
> On 18 June 2013 00:24, Andreas Färber <afaerber@suse.de> wrote:
> > As far as I can see, 1.3.0 is the latest available stable dtc version,
> > and it doesn't install libfdt_env.h yet apparently. Any chance we can
> > restore build with dtc 1.3.0 tarball (it used to work fine) while
> > keeping newer versions working?
> 
> I wanted to keep things simple, ie just require a distro
> version of libfdt to be installed the way upstream say it
> should be, rather than second-guessing whether a broken
> libfdt is or isn't going to work with our libfdt_env.h.
> Also, a lot of people out there are probably going to end
> up building against the submodule libfdt, so it's helpful
> to have at least some of the qemu developers building that
> way too...
> 
> > Also it seems that dtc submodule build is not multithreading-safe:
> 
> ...it helps reveal bugs like this one before release
> rather than afterwards. I'm having trouble figuring out
> why it doesn't work, though (I usually run with at least
> j3 and it's fine, plus the makefile rules are pretty
> simple) -- can you reproduce with V=1 so we can see what
> commands are actually being run?

Likewise.  I can't see why that wouldn't work.  V=1 might help,
although V=1 also changes the options to AR (adds verbose mode), so I
hope that doesn't mess up the results.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]