From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Carlos Maiolino <cmaiolino@redhat.com>, xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: fix sgid inheritance for subdirectories inheriting default acls
Date: Tue, 18 Jun 2013 15:53:51 +1000 [thread overview]
Message-ID: <20130618055351.GR29338@dastard> (raw)
In-Reply-To: <20130618045529.GA20365@infradead.org>
On Mon, Jun 17, 2013 at 09:55:29PM -0700, Christoph Hellwig wrote:
> On Tue, Jun 18, 2013 at 02:49:31PM +1000, Dave Chinner wrote:
> > xfs_set_mode()
> > {
> > setup iattr
> > return xfs_setattr_nonsize_nomodecheck()
> > }
>
> I'd rather opencode updating the mode here, it's really just a tiny bit
> of boilerplate code.
Needs a transaction, though. Right now, there's no transaction code
at all in xfs_acl.c and I'd kind of like to keep it that way as it's
just a translation layer....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-06-18 5:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-14 19:41 [PATCH] xfs: fix sgid inheritance for subdirectories inheriting default acls Carlos Maiolino
2013-06-17 12:16 ` Brian Foster
2013-06-18 4:49 ` Dave Chinner
2013-06-18 4:55 ` Christoph Hellwig
2013-06-18 5:53 ` Dave Chinner [this message]
2013-06-18 5:57 ` Christoph Hellwig
2013-06-18 6:21 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130618055351.GR29338@dastard \
--to=david@fromorbit.com \
--cc=cmaiolino@redhat.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.