From: Mark Brown <broonie@kernel.org>
To: "J, KEERTHY" <j-keerthy@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"ldewangan@nvidia.com" <ldewangan@nvidia.com>,
"sameo@linux.intel.com" <sameo@linux.intel.com>,
"grant.likely@secretlab.ca" <grant.likely@secretlab.ca>,
"swarren@nvidia.com" <swarren@nvidia.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"gg@slimlogic.co.uk" <gg@slimlogic.co.uk>
Subject: Re: [PATCH 1/4] MFD: Palmas: Add Interrupt feature
Date: Tue, 18 Jun 2013 09:58:25 +0100 [thread overview]
Message-ID: <20130618085825.GL1403@sirena.org.uk> (raw)
In-Reply-To: <DC88CAD03C0052499C1907B327FC63229EC277@DBDE04.ent.ti.com>
[-- Attachment #1: Type: text/plain, Size: 729 bytes --]
On Tue, Jun 18, 2013 at 05:15:03AM +0000, J, KEERTHY wrote:
> I understand your point. The IRQ is passed from device tree node.
> Say if the chip for some reason is not connected to any valid
> IRQ line the driver might end up requesting for a wrong IRQ line.
> So should I be validating the irq entry populated from device tree?
Yes, you should be checking that there's actually an interrupt there -
the number will be zero if there isn't.
> Explicitly checking on chip ID helps to avoid wrongly populated
> Device tree data.
Right, but on the other hand it ought to be possible to handle chips
that could but aren't configured to do interrupts and if the driver can
do that then this becomes redundant.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-06-18 8:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-17 12:09 [PATCH 0/4] MFD: Palmas: Add TPS659038 PMIC to supported devices of Palmas J Keerthy
2013-06-17 12:09 ` J Keerthy
2013-06-17 12:09 ` [PATCH 1/4] MFD: Palmas: Add Interrupt feature J Keerthy
2013-06-17 12:09 ` J Keerthy
2013-06-17 16:16 ` Mark Brown
2013-06-18 5:15 ` J, KEERTHY
2013-06-18 8:58 ` Mark Brown [this message]
2013-06-18 9:01 ` J, KEERTHY
2013-06-17 12:09 ` [PATCH 2/4] mfd: Palmas: Add TPS659038 PMIC support J Keerthy
2013-06-17 12:09 ` J Keerthy
2013-06-17 12:09 ` [PATCH 3/4] MFD: Palmas: Add SMPS10_BOOST feature J Keerthy
2013-06-17 12:09 ` J Keerthy
2013-06-17 12:09 ` [PATCH 4/4] regulator: Palmas: Add TPS659038 support J Keerthy
2013-06-17 12:09 ` J Keerthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130618085825.GL1403@sirena.org.uk \
--to=broonie@kernel.org \
--cc=gg@slimlogic.co.uk \
--cc=grant.likely@secretlab.ca \
--cc=j-keerthy@ti.com \
--cc=ldewangan@nvidia.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.