Re: [Qemu-devel] [RfC PATCH 2/2] console: add screendump-device qmp cmd

[Luiz Capitulino <lcapitulino@redhat.com>]

On Tue, 18 Jun 2013 11:24:54 +0200
Gerd Hoffmann <kraxel@redhat.com> wrote:

> On 06/17/13 16:50, Luiz Capitulino wrote:
> >>> > > +struct screendump_job {
> >>> > > +    QEMUBH *bh;
> >>> > > +    QemuConsole *con;
> >>> > > +    char *filename;
> >>> > > +};
> >> > 
> >> > We have a job API in the block layer.  Would it make sense to have a
> >> > QMP-level job interface?
> > I'd agree with this.
> 
> Something like the attached patch?  Which is just the bare minimum I'll
> need for screendump.  Basically a one-off bottom half with some monitor
> infrastructure (job id, error handling).  So it isn't for big jobs, but
> for small jobs which have to wait for something before they execute
> (spice-server, guest action, whatever).

I only skimmed over the patch, but you need QMP commands to cancel
and to query running jobs. Also, please move all this stuff to qmp.c
and do s/monitor/qmp rename.

Lastly, is it possible to have the block job QMP API on top of this
new QMP job API?