From: Theodore Ts'o <tytso@mit.edu>
To: Joe Perches <joe@perches.com>
Cc: linux-kernel@vger.kernel.org,
Dave Kleikamp <dave.kleikamp@oracle.com>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
linux-embedded@vger.kernel.org,
Andreas Dilger <adilger.kernel@dilger.ca>,
linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: Reduce object size when !CONFIG_PRINTK
Date: Tue, 18 Jun 2013 11:14:38 -0400 [thread overview]
Message-ID: <20130618151438.GC7359@thunk.org> (raw)
In-Reply-To: <a629c1c6359886419e24179dbb04484a88e6b0f2.1370400427.git.joe@perches.com>
On Tue, Jun 04, 2013 at 07:55:05PM -0700, Joe Perches wrote:
> Reduce the object size ~10% could be useful for embedded
> systems.
>
> Add #ifdef CONFIG_PRINTK #else #endif blocks
> to hold formats and arguments, passing " " to
> functions when !CONFIG_PRINTK and still verifying
> format and arguments with no_printk.
>
> $ size fs/ext4/built-in.o*
> text data bss dec hex filename
> 239375 610 888 240873 3ace9 fs/ext4/built-in.o.new
> 264167 738 888 265793 40e41 fs/ext4/built-in.o.old
>
> $ grep -E "CONFIG_EXT4|CONFIG_PRINTK" .config
> # CONFIG_PRINTK is not set
> CONFIG_EXT4_FS=y
> CONFIG_EXT4_USE_FOR_EXT23=y
> CONFIG_EXT4_FS_POSIX_ACL=y
> # CONFIG_EXT4_FS_SECURITY is not set
> # CONFIG_EXT4_DEBUG is not set
>
> Signed-off-by: Joe Perches <joe@perches.com>
Applied, thanks.
- Ted
prev parent reply other threads:[~2013-06-18 15:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-05 2:55 [PATCH] ext4: Reduce object size when !CONFIG_PRINTK Joe Perches
2013-06-18 15:14 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130618151438.GC7359@thunk.org \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=dave.kleikamp@oracle.com \
--cc=joe@perches.com \
--cc=linux-embedded@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.