From: Theodore Ts'o <tytso@mit.edu>
To: ashishsangwan2@gmail.com
Cc: adilger@dilger.ca, linux-ext4@vger.kernel.org,
Ashish Sangwan <a.sangwan@samsung.com>,
Namjae Jeon <namjae.jeon@samsung.com>
Subject: Re: [PATCH] ext4: optimize extent selection for block removal in case of hole punch
Date: Tue, 18 Jun 2013 11:40:53 -0400 [thread overview]
Message-ID: <20130618154053.GF7359@thunk.org> (raw)
In-Reply-To: <519f7ba2.04fc440a.06c2.ffffd589@mx.google.com>
On Fri, May 24, 2013 at 08:09:17PM +0530, ashishsangwan2@gmail.com wrote:
> From: Ashish Sangwan <a.sangwan@samsung.com>
>
> Both hole punch and truncate use ext4_ext_rm_leaf for removing
> blocks. Currently we choose the last extent as the starting
> point for removing blocks: ex = EXT_LAST_EXTENT(eh);
> This is OK for truncate but for hole punch we can optimize the
> extent selection as the path is already initialized.
> We could use this information to select proper starting extent.
> The code change in this patch will not affect truncate as for
> truncate path[depth].p_ext will always be NULL.
>
> Signed-off-by: Ashish Sangwan <a.sangwan@samsung.com>
> Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
Applied, thanks.
- Ted
next prev parent reply other threads:[~2013-06-18 15:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-24 14:39 [PATCH] ext4: optimize extent selection for block removal in case of hole punch ashishsangwan2
2013-06-18 15:40 ` Theodore Ts'o [this message]
2013-06-19 13:45 ` Ashish Sangwan
2013-06-19 14:06 ` Theodore Ts'o
2013-06-19 15:44 ` Ashish Sangwan
2013-06-23 18:43 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130618154053.GF7359@thunk.org \
--to=tytso@mit.edu \
--cc=a.sangwan@samsung.com \
--cc=adilger@dilger.ca \
--cc=ashishsangwan2@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=namjae.jeon@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.