From: Peter Zijlstra <peterz@infradead.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: mingo@redhat.com, linaro-kernel@lists.linaro.org,
patches@linaro.org, linux-kernel@vger.kernel.org,
robin.randhawa@arm.com, Steve.Bannister@arm.com,
Liviu.Dudau@arm.com, charles.garcia-tobin@arm.com,
arvind.chauhan@arm.com
Subject: Re: [PATCH 2/3] sched: don't call get_group() for covered cpus
Date: Tue, 18 Jun 2013 19:30:38 +0200 [thread overview]
Message-ID: <20130618173038.GD16094@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <CAKohpon_1StvME0nySHRzc2dHNTXHF5X6CXo5J6Rvtyb8wktRg@mail.gmail.com>
On Tue, Jun 18, 2013 at 08:59:39PM +0530, Viresh Kumar wrote:
> On 18 June 2013 20:49, Peter Zijlstra <peterz@infradead.org> wrote:
> > Sure. Just send a new patch and I'll substitute.
>
> This is the new log (patch is attached):
>
> sched: Fix memory leakage in build_sched_groups()
>
> In build_sched_groups() we don't need to call get_group() for cpus which are
> already covered in previous iterations. Calling get_group() would mark the group
> used and eventually leak it since we wouldn't connect it and not find it again
> to free it.
>
> This will happen only in cases where sg->cpumask contained more than one cpu
> (For any topology level). This patch would free sg's memory for all cpus leaving
> the group leader as the group isn't marked used now.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Thanks!
next prev parent reply other threads:[~2013-06-18 17:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-11 11:02 [PATCH 0/3] sched: Sched Domains: Fixups - Part 3 Viresh Kumar
2013-06-11 11:02 ` [PATCH 1/3] sched: Use cached value of span instead of calling sched_domain_span() Viresh Kumar
2013-06-19 18:40 ` [tip:sched/core] " tip-bot for Viresh Kumar
2013-06-11 11:02 ` [PATCH 2/3] sched: don't call get_group() for covered cpus Viresh Kumar
2013-06-18 10:03 ` Peter Zijlstra
2013-06-18 10:15 ` Viresh Kumar
2013-06-18 15:19 ` Peter Zijlstra
2013-06-18 15:29 ` Viresh Kumar
2013-06-18 17:30 ` Peter Zijlstra [this message]
2013-06-19 18:41 ` [tip:sched/core] sched: Fix memory leakage in build_sched_groups( ) tip-bot for Viresh Kumar
2013-06-11 11:02 ` [PATCH 3/3] sched: remove WARN_ON(!sd) from init_sched_groups_power() Viresh Kumar
2013-06-18 10:03 ` Peter Zijlstra
2013-06-19 18:41 ` [tip:sched/core] sched: Remove " tip-bot for Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130618173038.GD16094@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=Liviu.Dudau@arm.com \
--cc=Steve.Bannister@arm.com \
--cc=arvind.chauhan@arm.com \
--cc=charles.garcia-tobin@arm.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=patches@linaro.org \
--cc=robin.randhawa@arm.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.