From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Pavel Machek <pavel@denx.de>
Cc: Grant Likely <grant.likely@secretlab.ca>,
Detlev Zundel <dzu@denx.de>, "Hans J. Koch" <hjk@hansjkoch.de>,
Rob Herring <rob.herring@calxeda.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
trivial <trivial@kernel.org>
Subject: Re: [PATCH] fix UIO with device tree but no assigned interrupt
Date: Tue, 18 Jun 2013 10:58:22 -0700 [thread overview]
Message-ID: <20130618175822.GB8386@kroah.com> (raw)
In-Reply-To: <20130618142634.GB17361@amd.pavel.ucw.cz>
On Tue, Jun 18, 2013 at 04:26:34PM +0200, Pavel Machek wrote:
>
> If device is initialized from device tree, but has no interrupt
> assigned, uio will still try to request and interrupt old way,
> fails, and fails registration.
>
> This is wrong; don't try initializing irq using platform data if
> device tree is available.
>
> Simplified code based on suggestion by Grant Likely.
>
> Fixed memory leak in "irq can not be registered" error path.
>
> Signed-off-by: Pavel Machek <pavel@denx.de>
> Reported-by: Detlev Zundel <dzu@denx.de>
I see a ton of patches in this thread, and have no idea which one is
"newest" and correct.
Please resend, in a format that I do not have to edit at all (hint, the
subject line counts), that I can apply properly.
thanks,
greg k-h
next prev parent reply other threads:[~2013-06-18 17:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-17 13:49 [PATCH] fix UIO with device tree but no assigned interrupt Pavel Machek
2013-06-17 23:46 ` Greg KH
2013-06-18 12:53 ` Pavel Machek
2013-06-18 9:03 ` Grant Likely
2013-06-18 12:52 ` Pavel Machek
2013-06-18 14:08 ` Grant Likely
2013-06-18 14:24 ` Pavel Machek
2013-06-18 14:26 ` Pavel Machek
2013-06-18 17:58 ` Greg Kroah-Hartman [this message]
2013-06-18 20:37 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130618175822.GB8386@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=dzu@denx.de \
--cc=grant.likely@secretlab.ca \
--cc=hjk@hansjkoch.de \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@denx.de \
--cc=rob.herring@calxeda.com \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.