All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jubin Mehta <jubin.mehta@intel.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Vinod Koul <vinod.koul@intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Dan Williams <djbw@fb.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Dave Jiang <dave.jiang@intel.com>,
	Jon Mason <jon.mason@intel.com>
Subject: Re: [PATCH] dmatest: masking tests for channel capabilities
Date: Tue, 18 Jun 2013 10:58:45 -0700	[thread overview]
Message-ID: <20130618175844.GC5054@intel.com> (raw)
In-Reply-To: <CAHp75Ved4kJ6vZPvCcNcZxJgCJKUb-ZCrCNXFJ84DzK095iDPA@mail.gmail.com>

On Mon, Jun 17, 2013 at 11:59:00AM +0300, Andy Shevchenko wrote:
> > +PATH = /sys/kernel/debug/dmatest/cap_mask
> > +(DEFAULT) echo 0x07 > $PATH     // Set Bits 0,1,2 for MEMCPY, XOR and PQ
> > +          echo 0x01 > $PATH     // Set bit 0 to enable MEMCPY
> > +          echo 0x02 > $PATH     // Set bit 1 to enable XOR
> > +          echo 0x04 > $PATH     // Set bit 2 to enable PQ
> 
> What if we make examples  followed by # and comments?
> And move (DEFAULT) to the commentary.
>
Yes, I shall fix the issue in the next patch.
 
Regards,
Jubin 

  parent reply	other threads:[~2013-06-18 17:58 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-13 17:24 [PATCH] dmatest: masking tests for channel capabilities Jubin Mehta
2013-06-17  8:59 ` Andy Shevchenko
2013-06-17 15:34   ` Jon Mason
2013-06-17 15:55   ` Dave Jiang
2013-06-18 17:58   ` Jubin Mehta [this message]
     [not found] ` <CAA9_cmf5y_z_XeX7N2Jno9uvUkrFK83RN1XrxTwVqZJnbdfEWA@mail.gmail.com>
2013-06-17 21:12   ` Dan Williams
2013-06-18  5:57     ` Andy Shevchenko
2013-06-18 17:34     ` Jubin Mehta
2013-06-18 19:16       ` Dan Williams
2013-06-18 20:01         ` Andy Shevchenko
2013-06-18 20:44           ` Dan Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130618175844.GC5054@intel.com \
    --to=jubin.mehta@intel.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=dave.jiang@intel.com \
    --cc=djbw@fb.com \
    --cc=jon.mason@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.