From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Tue, 18 Jun 2013 18:16:26 +0200 Subject: [PATCH v3 10/12] ARM: mvebu: Relocate Armada 370/XP DeviceBus device tree nodes In-Reply-To: <1371554737-25319-11-git-send-email-ezequiel.garcia@free-electrons.com> References: <1371554737-25319-1-git-send-email-ezequiel.garcia@free-electrons.com> <1371554737-25319-11-git-send-email-ezequiel.garcia@free-electrons.com> Message-ID: <201306181816.26530.arnd@arndb.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tuesday 18 June 2013, Ezequiel Garcia wrote: > > + devbus-bootcs { > + compatible = "marvell,mvebu-devbus"; > + reg = <0xffff0001 0x10400 0x8>; > + ranges = <0 MBUS_ID(0x01, 0x2f) 0 0xffffffff>; > + #address-cells = <1>; > + #size-cells = <1>; > + clocks = <&coreclk 0>; > + status = "disabled"; > + }; This is a violation of the binding as far as I can tell, since you don't specify ranges to access the 0xffff0001 0x10400 address. However, as I explained in my comment for the binding, I think you should clarify the binding and leave the implementation as you have it here. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH v3 10/12] ARM: mvebu: Relocate Armada 370/XP DeviceBus device tree nodes Date: Tue, 18 Jun 2013 18:16:26 +0200 Message-ID: <201306181816.26530.arnd@arndb.de> References: <1371554737-25319-1-git-send-email-ezequiel.garcia@free-electrons.com> <1371554737-25319-11-git-send-email-ezequiel.garcia@free-electrons.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1371554737-25319-11-git-send-email-ezequiel.garcia-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Ezequiel Garcia Cc: Andrew Lunn , Jason Cooper , devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Jason Gunthorpe , Maen Suleiman , Lior Amsalem , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Sebastian Hesselbarth List-Id: devicetree@vger.kernel.org On Tuesday 18 June 2013, Ezequiel Garcia wrote: > > + devbus-bootcs { > + compatible = "marvell,mvebu-devbus"; > + reg = <0xffff0001 0x10400 0x8>; > + ranges = <0 MBUS_ID(0x01, 0x2f) 0 0xffffffff>; > + #address-cells = <1>; > + #size-cells = <1>; > + clocks = <&coreclk 0>; > + status = "disabled"; > + }; This is a violation of the binding as far as I can tell, since you don't specify ranges to access the 0xffff0001 0x10400 address. However, as I explained in my comment for the binding, I think you should clarify the binding and leave the implementation as you have it here. Arnd