From mboxrd@z Thu Jan 1 00:00:00 1970 From: ezequiel.garcia@free-electrons.com (Ezequiel Garcia) Date: Tue, 18 Jun 2013 16:47:57 -0300 Subject: [PATCH] ARM: Kirkwood: Fix the internal register ranges translation In-Reply-To: <51C0B838.90809@gmail.com> References: <1371569479-31498-1-git-send-email-ezequiel.garcia@free-electrons.com> <51C0B838.90809@gmail.com> Message-ID: <20130618194756.GA2470@localhost> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Jun 18, 2013 at 09:42:48PM +0200, Sebastian Hesselbarth wrote: > On 06/18/2013 05:31 PM, Ezequiel Garcia wrote: > > Although the internal register window size is 1 MiB, the previous > > ranges translation for the internal register space had a size of > > 0x4000000. This was done to allow the crypto and nand node to access > > the corresponding 'sram' and 'nand' decoding windows. > > > > In order to describe the hardware more accurately, we declare the > > real 1 MiB internal register space in the ranges, and add a translation > > entry for the nand node to access the 'nand' window. > > > > This commit will make future improvements on the MBus DT binding easier. > > > > Signed-off-by: Ezequiel Garcia > > --- > > Tested on Plathome Openblocks A6 board. > > > > arch/arm/boot/dts/kirkwood.dtsi | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/arch/arm/boot/dts/kirkwood.dtsi b/arch/arm/boot/dts/kirkwood.dtsi > > index 8a1e3bb..910fabc 100644 > > --- a/arch/arm/boot/dts/kirkwood.dtsi > > +++ b/arch/arm/boot/dts/kirkwood.dtsi > > @@ -38,7 +38,8 @@ > > > > ocp at f1000000 { > > compatible = "simple-bus"; > > - ranges =<0x00000000 0xf1000000 0x4000000 > > + ranges =<0x00000000 0xf1000000 0x0100000 > > + 0xf4000000 0xf4000000 0x0000400 > > 0xf5000000 0xf5000000 0x0000400>; > > Ezequiel, > > maybe you should also put a comment at the end of each ranges > line to name the remap it does? > > Also, as already mentioned on IRC, it would be great to also > have dove.dtsi updated accordingly. > Indeed, I will do both. Thanks! -- Ezequiel Garc?a, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ezequiel Garcia Subject: Re: [PATCH] ARM: Kirkwood: Fix the internal register ranges translation Date: Tue, 18 Jun 2013 16:47:57 -0300 Message-ID: <20130618194756.GA2470@localhost> References: <1371569479-31498-1-git-send-email-ezequiel.garcia@free-electrons.com> <51C0B838.90809@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <51C0B838.90809-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Sebastian Hesselbarth Cc: Lior Amsalem , Andrew Lunn , Jason Cooper , devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Jason Gunthorpe , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org T24gVHVlLCBKdW4gMTgsIDIwMTMgYXQgMDk6NDI6NDhQTSArMDIwMCwgU2ViYXN0aWFuIEhlc3Nl bGJhcnRoIHdyb3RlOgo+IE9uIDA2LzE4LzIwMTMgMDU6MzEgUE0sIEV6ZXF1aWVsIEdhcmNpYSB3 cm90ZToKPiA+IEFsdGhvdWdoIHRoZSBpbnRlcm5hbCByZWdpc3RlciB3aW5kb3cgc2l6ZSBpcyAx IE1pQiwgdGhlIHByZXZpb3VzCj4gPiByYW5nZXMgdHJhbnNsYXRpb24gZm9yIHRoZSBpbnRlcm5h bCByZWdpc3RlciBzcGFjZSBoYWQgYSBzaXplIG9mCj4gPiAweDQwMDAwMDAuIFRoaXMgd2FzIGRv bmUgdG8gYWxsb3cgdGhlIGNyeXB0byBhbmQgbmFuZCBub2RlIHRvIGFjY2Vzcwo+ID4gdGhlIGNv cnJlc3BvbmRpbmcgJ3NyYW0nIGFuZCAnbmFuZCcgZGVjb2Rpbmcgd2luZG93cy4KPiA+Cj4gPiBJ biBvcmRlciB0byBkZXNjcmliZSB0aGUgaGFyZHdhcmUgbW9yZSBhY2N1cmF0ZWx5LCB3ZSBkZWNs YXJlIHRoZQo+ID4gcmVhbCAxIE1pQiBpbnRlcm5hbCByZWdpc3RlciBzcGFjZSBpbiB0aGUgcmFu Z2VzLCBhbmQgYWRkIGEgdHJhbnNsYXRpb24KPiA+IGVudHJ5IGZvciB0aGUgbmFuZCBub2RlIHRv IGFjY2VzcyB0aGUgJ25hbmQnIHdpbmRvdy4KPiA+Cj4gPiBUaGlzIGNvbW1pdCB3aWxsIG1ha2Ug ZnV0dXJlIGltcHJvdmVtZW50cyBvbiB0aGUgTUJ1cyBEVCBiaW5kaW5nIGVhc2llci4KPiA+Cj4g PiBTaWduZWQtb2ZmLWJ5OiBFemVxdWllbCBHYXJjaWE8ZXplcXVpZWwuZ2FyY2lhQGZyZWUtZWxl Y3Ryb25zLmNvbT4KPiA+IC0tLQo+ID4gVGVzdGVkIG9uIFBsYXRob21lIE9wZW5ibG9ja3MgQTYg Ym9hcmQuCj4gPgo+ID4gICBhcmNoL2FybS9ib290L2R0cy9raXJrd29vZC5kdHNpIHwgNSArKyst LQo+ID4gICAxIGZpbGUgY2hhbmdlZCwgMyBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQo+ ID4KPiA+IGRpZmYgLS1naXQgYS9hcmNoL2FybS9ib290L2R0cy9raXJrd29vZC5kdHNpIGIvYXJj aC9hcm0vYm9vdC9kdHMva2lya3dvb2QuZHRzaQo+ID4gaW5kZXggOGExZTNiYi4uOTEwZmFiYyAx MDA2NDQKPiA+IC0tLSBhL2FyY2gvYXJtL2Jvb3QvZHRzL2tpcmt3b29kLmR0c2kKPiA+ICsrKyBi L2FyY2gvYXJtL2Jvb3QvZHRzL2tpcmt3b29kLmR0c2kKPiA+IEBAIC0zOCw3ICszOCw4IEBACj4g Pgo+ID4gICAJb2NwQGYxMDAwMDAwIHsKPiA+ICAgCQljb21wYXRpYmxlID0gInNpbXBsZS1idXMi Owo+ID4gLQkJcmFuZ2VzID08MHgwMDAwMDAwMCAweGYxMDAwMDAwIDB4NDAwMDAwMAo+ID4gKwkJ cmFuZ2VzID08MHgwMDAwMDAwMCAweGYxMDAwMDAwIDB4MDEwMDAwMAo+ID4gKwkJICAgICAgICAg IDB4ZjQwMDAwMDAgMHhmNDAwMDAwMCAweDAwMDA0MDAKPiA+ICAgCQkgICAgICAgICAgMHhmNTAw MDAwMCAweGY1MDAwMDAwIDB4MDAwMDQwMD47Cj4gCj4gRXplcXVpZWwsCj4gCj4gbWF5YmUgeW91 IHNob3VsZCBhbHNvIHB1dCBhIGNvbW1lbnQgYXQgdGhlIGVuZCBvZiBlYWNoIHJhbmdlcwo+IGxp bmUgdG8gbmFtZSB0aGUgcmVtYXAgaXQgZG9lcz8KPiAKPiBBbHNvLCBhcyBhbHJlYWR5IG1lbnRp b25lZCBvbiBJUkMsIGl0IHdvdWxkIGJlIGdyZWF0IHRvIGFsc28KPiBoYXZlIGRvdmUuZHRzaSB1 cGRhdGVkIGFjY29yZGluZ2x5Lgo+IAoKSW5kZWVkLCBJIHdpbGwgZG8gYm90aC4KClRoYW5rcyEK LS0gCkV6ZXF1aWVsIEdhcmPDrWEsIEZyZWUgRWxlY3Ryb25zCkVtYmVkZGVkIExpbnV4LCBLZXJu ZWwgYW5kIEFuZHJvaWQgRW5naW5lZXJpbmcKaHR0cDovL2ZyZWUtZWxlY3Ryb25zLmNvbQpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkZXZpY2V0cmVlLWRp c2N1c3MgbWFpbGluZyBsaXN0CmRldmljZXRyZWUtZGlzY3Vzc0BsaXN0cy5vemxhYnMub3JnCmh0 dHBzOi8vbGlzdHMub3psYWJzLm9yZy9saXN0aW5mby9kZXZpY2V0cmVlLWRpc2N1c3MK