From mboxrd@z Thu Jan 1 00:00:00 1970 From: ezequiel.garcia@free-electrons.com (Ezequiel Garcia) Date: Tue, 18 Jun 2013 19:09:30 -0300 Subject: [PATCH v3 10/12] ARM: mvebu: Relocate Armada 370/XP DeviceBus device tree nodes In-Reply-To: <201306181816.26530.arnd@arndb.de> References: <1371554737-25319-1-git-send-email-ezequiel.garcia@free-electrons.com> <1371554737-25319-11-git-send-email-ezequiel.garcia@free-electrons.com> <201306181816.26530.arnd@arndb.de> Message-ID: <20130618220929.GA24056@localhost> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Jun 18, 2013 at 06:16:26PM +0200, Arnd Bergmann wrote: > On Tuesday 18 June 2013, Ezequiel Garcia wrote: > > > > + devbus-bootcs { > > + compatible = "marvell,mvebu-devbus"; > > + reg = <0xffff0001 0x10400 0x8>; > > + ranges = <0 MBUS_ID(0x01, 0x2f) 0 0xffffffff>; > > + #address-cells = <1>; > > + #size-cells = <1>; > > + clocks = <&coreclk 0>; > > + status = "disabled"; > > + }; > > This is a violation of the binding as far as I can tell, since you don't specify ranges > to access the 0xffff0001 0x10400 address. However, as I explained in my comment for > the binding, I think you should clarify the binding and leave the implementation > as you have it here. > Mmm... again I got lost here. Which 'ranges' you say I don't specify to access the (formerly) 0xffff0001? AFAIK, 'ranges' are only for children translation, which means I don't need to specify a ranges for that in the devbus node, but in its parent, right? This ranges thing can be very tricky, so please correct me if I'm mistaken. -- Ezequiel Garc?a, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ezequiel Garcia Subject: Re: [PATCH v3 10/12] ARM: mvebu: Relocate Armada 370/XP DeviceBus device tree nodes Date: Tue, 18 Jun 2013 19:09:30 -0300 Message-ID: <20130618220929.GA24056@localhost> References: <1371554737-25319-1-git-send-email-ezequiel.garcia@free-electrons.com> <1371554737-25319-11-git-send-email-ezequiel.garcia@free-electrons.com> <201306181816.26530.arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <201306181816.26530.arnd-r2nGTMty4D4@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Arnd Bergmann Cc: Andrew Lunn , Jason Cooper , devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Jason Gunthorpe , Maen Suleiman , Lior Amsalem , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Sebastian Hesselbarth List-Id: devicetree@vger.kernel.org T24gVHVlLCBKdW4gMTgsIDIwMTMgYXQgMDY6MTY6MjZQTSArMDIwMCwgQXJuZCBCZXJnbWFubiB3 cm90ZToKPiBPbiBUdWVzZGF5IDE4IEp1bmUgMjAxMywgRXplcXVpZWwgR2FyY2lhIHdyb3RlOgo+ ID4gCj4gPiArICAgICAgICAgICAgICAgZGV2YnVzLWJvb3RjcyB7Cj4gPiArICAgICAgICAgICAg ICAgICAgICAgICBjb21wYXRpYmxlID0gIm1hcnZlbGwsbXZlYnUtZGV2YnVzIjsKPiA+ICsgICAg ICAgICAgICAgICAgICAgICAgIHJlZyA9IDwweGZmZmYwMDAxIDB4MTA0MDAgMHg4PjsKPiA+ICsg ICAgICAgICAgICAgICAgICAgICAgIHJhbmdlcyA9IDwwIE1CVVNfSUQoMHgwMSwgMHgyZikgMCAw eGZmZmZmZmZmPjsKPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICNhZGRyZXNzLWNlbGxzID0g PDE+Owo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgI3NpemUtY2VsbHMgPSA8MT47Cj4gPiAr ICAgICAgICAgICAgICAgICAgICAgICBjbG9ja3MgPSA8JmNvcmVjbGsgMD47Cj4gPiArICAgICAg ICAgICAgICAgICAgICAgICBzdGF0dXMgPSAiZGlzYWJsZWQiOwo+ID4gKyAgICAgICAgICAgICAg IH07Cj4gCj4gVGhpcyBpcyBhIHZpb2xhdGlvbiBvZiB0aGUgYmluZGluZyBhcyBmYXIgYXMgSSBj YW4gdGVsbCwgc2luY2UgeW91IGRvbid0IHNwZWNpZnkgcmFuZ2VzCj4gdG8gYWNjZXNzIHRoZSAw eGZmZmYwMDAxIDB4MTA0MDAgYWRkcmVzcy4gSG93ZXZlciwgYXMgSSBleHBsYWluZWQgaW4gbXkg Y29tbWVudCBmb3IKPiB0aGUgYmluZGluZywgSSB0aGluayB5b3Ugc2hvdWxkIGNsYXJpZnkgdGhl IGJpbmRpbmcgYW5kIGxlYXZlIHRoZSBpbXBsZW1lbnRhdGlvbgo+IGFzIHlvdSBoYXZlIGl0IGhl cmUuCj4gCgpNbW0uLi4gYWdhaW4gSSBnb3QgbG9zdCBoZXJlLiBXaGljaCAncmFuZ2VzJyB5b3Ug c2F5IEkgZG9uJ3Qgc3BlY2lmeSB0bwphY2Nlc3MgdGhlIChmb3JtZXJseSkgMHhmZmZmMDAwMT8K CkFGQUlLLCAncmFuZ2VzJyBhcmUgb25seSBmb3IgY2hpbGRyZW4gdHJhbnNsYXRpb24sIHdoaWNo IG1lYW5zIEkgZG9uJ3QKbmVlZCB0byBzcGVjaWZ5IGEgcmFuZ2VzIGZvciB0aGF0IGluIHRoZSBk ZXZidXMgbm9kZSwgYnV0IGluIGl0cyBwYXJlbnQsCnJpZ2h0PwoKVGhpcyByYW5nZXMgdGhpbmcg Y2FuIGJlIHZlcnkgdHJpY2t5LCBzbyBwbGVhc2UgY29ycmVjdCBtZSBpZiBJJ20KbWlzdGFrZW4u CgotLSAKRXplcXVpZWwgR2FyY8OtYSwgRnJlZSBFbGVjdHJvbnMKRW1iZWRkZWQgTGludXgsIEtl cm5lbCBhbmQgQW5kcm9pZCBFbmdpbmVlcmluZwpodHRwOi8vZnJlZS1lbGVjdHJvbnMuY29tCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRldmljZXRyZWUt ZGlzY3VzcyBtYWlsaW5nIGxpc3QKZGV2aWNldHJlZS1kaXNjdXNzQGxpc3RzLm96bGFicy5vcmcK aHR0cHM6Ly9saXN0cy5vemxhYnMub3JnL2xpc3RpbmZvL2RldmljZXRyZWUtZGlzY3Vzcwo=