From mboxrd@z Thu Jan 1 00:00:00 1970 From: ezequiel.garcia@free-electrons.com (Ezequiel Garcia) Date: Tue, 18 Jun 2013 19:14:37 -0300 Subject: [PATCH v3 10/12] ARM: mvebu: Relocate Armada 370/XP DeviceBus device tree nodes In-Reply-To: <20130618220929.GA24056@localhost> References: <1371554737-25319-1-git-send-email-ezequiel.garcia@free-electrons.com> <1371554737-25319-11-git-send-email-ezequiel.garcia@free-electrons.com> <201306181816.26530.arnd@arndb.de> <20130618220929.GA24056@localhost> Message-ID: <20130618221436.GB24056@localhost> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Jun 18, 2013 at 07:09:29PM -0300, Ezequiel Garcia wrote: > On Tue, Jun 18, 2013 at 06:16:26PM +0200, Arnd Bergmann wrote: > > On Tuesday 18 June 2013, Ezequiel Garcia wrote: > > > > > > + devbus-bootcs { > > > + compatible = "marvell,mvebu-devbus"; > > > + reg = <0xffff0001 0x10400 0x8>; > > > + ranges = <0 MBUS_ID(0x01, 0x2f) 0 0xffffffff>; > > > + #address-cells = <1>; > > > + #size-cells = <1>; > > > + clocks = <&coreclk 0>; > > > + status = "disabled"; > > > + }; > > > > This is a violation of the binding as far as I can tell, since you don't specify ranges > > to access the 0xffff0001 0x10400 address. However, as I explained in my comment for > > the binding, I think you should clarify the binding and leave the implementation > > as you have it here. > > > > Mmm... again I got lost here. Which 'ranges' you say I don't specify to > access the (formerly) 0xffff0001? > Oh, maybe you meant I'm not specifying an mbus-node ranges translation in this same patch in this .dtsi file I'm modifying? In that case, that's on purpose to avoid the nightmare involved in mixing 'ranges' in per-board .dts files together with the ranges declared in each included .dtsi. By having only one mbus-node ranges property, per-board, it gets a bit simpler. -- Ezequiel Garc?a, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ezequiel Garcia Subject: Re: [PATCH v3 10/12] ARM: mvebu: Relocate Armada 370/XP DeviceBus device tree nodes Date: Tue, 18 Jun 2013 19:14:37 -0300 Message-ID: <20130618221436.GB24056@localhost> References: <1371554737-25319-1-git-send-email-ezequiel.garcia@free-electrons.com> <1371554737-25319-11-git-send-email-ezequiel.garcia@free-electrons.com> <201306181816.26530.arnd@arndb.de> <20130618220929.GA24056@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20130618220929.GA24056@localhost> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Arnd Bergmann Cc: Andrew Lunn , Jason Cooper , devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Jason Gunthorpe , Maen Suleiman , Lior Amsalem , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Sebastian Hesselbarth List-Id: devicetree@vger.kernel.org T24gVHVlLCBKdW4gMTgsIDIwMTMgYXQgMDc6MDk6MjlQTSAtMDMwMCwgRXplcXVpZWwgR2FyY2lh IHdyb3RlOgo+IE9uIFR1ZSwgSnVuIDE4LCAyMDEzIGF0IDA2OjE2OjI2UE0gKzAyMDAsIEFybmQg QmVyZ21hbm4gd3JvdGU6Cj4gPiBPbiBUdWVzZGF5IDE4IEp1bmUgMjAxMywgRXplcXVpZWwgR2Fy Y2lhIHdyb3RlOgo+ID4gPiAKPiA+ID4gKyAgICAgICAgICAgICAgIGRldmJ1cy1ib290Y3Mgewo+ ID4gPiArICAgICAgICAgICAgICAgICAgICAgICBjb21wYXRpYmxlID0gIm1hcnZlbGwsbXZlYnUt ZGV2YnVzIjsKPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgcmVnID0gPDB4ZmZmZjAwMDEg MHgxMDQwMCAweDg+Owo+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICByYW5nZXMgPSA8MCBN QlVTX0lEKDB4MDEsIDB4MmYpIDAgMHhmZmZmZmZmZj47Cj4gPiA+ICsgICAgICAgICAgICAgICAg ICAgICAgICNhZGRyZXNzLWNlbGxzID0gPDE+Owo+ID4gPiArICAgICAgICAgICAgICAgICAgICAg ICAjc2l6ZS1jZWxscyA9IDwxPjsKPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgY2xvY2tz ID0gPCZjb3JlY2xrIDA+Owo+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICBzdGF0dXMgPSAi ZGlzYWJsZWQiOwo+ID4gPiArICAgICAgICAgICAgICAgfTsKPiA+IAo+ID4gVGhpcyBpcyBhIHZp b2xhdGlvbiBvZiB0aGUgYmluZGluZyBhcyBmYXIgYXMgSSBjYW4gdGVsbCwgc2luY2UgeW91IGRv bid0IHNwZWNpZnkgcmFuZ2VzCj4gPiB0byBhY2Nlc3MgdGhlIDB4ZmZmZjAwMDEgMHgxMDQwMCBh ZGRyZXNzLiBIb3dldmVyLCBhcyBJIGV4cGxhaW5lZCBpbiBteSBjb21tZW50IGZvcgo+ID4gdGhl IGJpbmRpbmcsIEkgdGhpbmsgeW91IHNob3VsZCBjbGFyaWZ5IHRoZSBiaW5kaW5nIGFuZCBsZWF2 ZSB0aGUgaW1wbGVtZW50YXRpb24KPiA+IGFzIHlvdSBoYXZlIGl0IGhlcmUuCj4gPiAKPiAKPiBN bW0uLi4gYWdhaW4gSSBnb3QgbG9zdCBoZXJlLiBXaGljaCAncmFuZ2VzJyB5b3Ugc2F5IEkgZG9u J3Qgc3BlY2lmeSB0bwo+IGFjY2VzcyB0aGUgKGZvcm1lcmx5KSAweGZmZmYwMDAxPwo+IAoKT2gs IG1heWJlIHlvdSBtZWFudCBJJ20gbm90IHNwZWNpZnlpbmcgYW4gbWJ1cy1ub2RlIHJhbmdlcyB0 cmFuc2xhdGlvbgppbiB0aGlzIHNhbWUgcGF0Y2ggaW4gdGhpcyAuZHRzaSBmaWxlIEknbSBtb2Rp Znlpbmc/CgpJbiB0aGF0IGNhc2UsIHRoYXQncyBvbiBwdXJwb3NlIHRvIGF2b2lkIHRoZSBuaWdo dG1hcmUgaW52b2x2ZWQgaW4KbWl4aW5nICdyYW5nZXMnIGluIHBlci1ib2FyZCAuZHRzIGZpbGVz IHRvZ2V0aGVyIHdpdGggdGhlIHJhbmdlcwpkZWNsYXJlZCBpbiBlYWNoIGluY2x1ZGVkIC5kdHNp LgoKQnkgaGF2aW5nIG9ubHkgb25lIG1idXMtbm9kZSByYW5nZXMgcHJvcGVydHksIHBlci1ib2Fy ZCwgaXQgZ2V0cyBhIGJpdApzaW1wbGVyLgoKLS0gCkV6ZXF1aWVsIEdhcmPDrWEsIEZyZWUgRWxl Y3Ryb25zCkVtYmVkZGVkIExpbnV4LCBLZXJuZWwgYW5kIEFuZHJvaWQgRW5naW5lZXJpbmcKaHR0 cDovL2ZyZWUtZWxlY3Ryb25zLmNvbQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpkZXZpY2V0cmVlLWRpc2N1c3MgbWFpbGluZyBsaXN0CmRldmljZXRyZWUt ZGlzY3Vzc0BsaXN0cy5vemxhYnMub3JnCmh0dHBzOi8vbGlzdHMub3psYWJzLm9yZy9saXN0aW5m by9kZXZpY2V0cmVlLWRpc2N1c3MK